From: Peter Korsgaard <peter@korsgaard.com>
To: patrick.oppenlander@gmail.com
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] package/minisign: new package
Date: Wed, 07 Feb 2024 09:16:29 +0100 [thread overview]
Message-ID: <87bk8s3d0i.fsf@48ers.dk> (raw)
In-Reply-To: <20240108222957.3567-1-patrick.oppenlander@gmail.com> (patrick oppenlander's message of "Tue, 9 Jan 2024 09:25:51 +1100")
>>>>> "patrick" == patrick oppenlander <patrick.oppenlander@gmail.com> writes:
> From: Patrick Oppenlander <patrick.oppenlander@gmail.com>
> Signed-off-by: Patrick Oppenlander <patrick.oppenlander@gmail.com>
> ---
> Changes from v1 (reviewed by Baruch Siach):
> * host-libsodium dependency was incorrectly on to the target dependencies list.
./utils/check-package points out a few minor issues:
package/Config.in:1572: Packages in: menu "Crypto",
are not alphabetically ordered;
correct order: '-', '_', digits, capitals, lowercase;
first incorrect package: minisign
package/minisign/Config.in:6: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
package/minisign/Config.in.host:4: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
You put it in Libraries/Crypto, but I isn't a library, so I think it
makes more sense to put it under "shell and utilities" like we do for gnupg2.
Committed with those issues fixed and an entry in DEVELOPERS added, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-02-07 8:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 22:25 [Buildroot] [PATCH v2] package/minisign: new package patrick.oppenlander
2024-02-07 8:16 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bk8s3d0i.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=patrick.oppenlander@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox