Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: patrick.oppenlander@gmail.com
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/minisign: new package
Date: Mon, 08 Jan 2024 08:28:58 +0200	[thread overview]
Message-ID: <87bk9w2v2v.fsf@tarshish> (raw)
In-Reply-To: <20240108013056.39493-1-patrick.oppenlander@gmail.com>

Hi Patrick,

On Mon, Jan 08 2024, patrick.oppenlander@gmail.com wrote:
[snip]
> new file mode 100644
> index 0000000000..d6be41b2fe
> --- /dev/null
> +++ b/package/minisign/minisign.mk
> @@ -0,0 +1,18 @@
> +################################################################################
> +#
> +# minisign
> +#
> +################################################################################
> +
> +MINISIGN_VERSION = 0.11
> +MINISIGN_SITE = $(call github,jedisct1,minisign,$(MINISIGN_VERSION))
> +MINISIGN_LICENSE = ISC
> +MINISIGN_LICENSE_FILES = LICENSE
> +MINISIGN_DEPENDENCIES = host-libsodium libsodium

Does target minisign need both libsodum and host-libsodium?

What about host-minisign? Doesn't it need host-libsodium to build?

To add dependencies to the host package, set HOST_MINISIGN_DEPENDENCIES.

baruch

> +
> +ifeq ($(BR2_STATIC_LIBS),y)
> +MINISIGN_CONF_OPTS += -DBUILD_STATIC_EXECUTABLES=1
> +endif
> +
> +$(eval $(cmake-package))
> +$(eval $(host-cmake-package))


-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-01-08  6:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-08  1:30 [Buildroot] [PATCH] package/minisign: new package patrick.oppenlander
2024-01-08  6:28 ` Baruch Siach via buildroot [this message]
2024-01-08 22:17   ` Patrick Oppenlander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bk9w2v2v.fsf@tarshish \
    --to=buildroot@buildroot.org \
    --cc=baruch@tkos.co.il \
    --cc=patrick.oppenlander@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox