Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: "José Luis Salvador Rufo" <salvador.joseluis@gmail.com>
Cc: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] docs/manual/prerequisite.txt: add diffutils
Date: Tue, 26 Apr 2022 20:16:12 +0300	[thread overview]
Message-ID: <87bkwn21vp.fsf@tarshish> (raw)
In-Reply-To: <20220426132833.1579873-1-salvador.joseluis@gmail.com>

Hi José,

On Tue, Apr 26 2022, José Luis Salvador Rufo wrote:
> Patch title: docs/manual/prerequisite.txt: add diffutils

No need for this line in the commit log body. The email subject line
appears as head line of the git commit once applied.

> The command `cmp` is used by `package/pkg-generic.mk` at commit
> 8623cc5deb5. This command is provided by `diffutils`.

Actually, we have host-diffutils, so we can build cmp if the host does
not have it installed. All we need is support added under
support/dependencies/ like a few other utilities.

We also don't list findutils as prerequisite, even though we rely
heavily on the 'find' utility.

baruch

> Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com>
> ---
>  docs/manual/prerequisite.txt | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/docs/manual/prerequisite.txt b/docs/manual/prerequisite.txt
> index 40071491f8..763fe79041 100644
> --- a/docs/manual/prerequisite.txt
> +++ b/docs/manual/prerequisite.txt
> @@ -23,6 +23,7 @@ between distributions).
>  ** +make+ (version 3.81 or any later)
>  ** +binutils+
>  ** +build-essential+ (only for Debian based systems)
> +** +diffutils+
>  ** +gcc+ (version 4.8 or any later)
>  ** `g++` (version 4.8 or any later)
>  ** +bash+


-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-04-26 17:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-26 13:28 [Buildroot] [PATCH 1/1] docs/manual/prerequisite.txt: add diffutils José Luis Salvador Rufo
2022-04-26 17:16 ` Baruch Siach via buildroot [this message]
2022-04-26 22:01   ` Thomas Petazzoni via buildroot
2022-04-27  4:34     ` Baruch Siach via buildroot
2022-04-27  6:22     ` José Luis Salvador Rufo
2022-07-26 22:04 ` Thomas Petazzoni via buildroot
2022-08-29 11:15   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkwn21vp.fsf@tarshish \
    --to=buildroot@buildroot.org \
    --cc=baruch@tkos.co.il \
    --cc=salvador.joseluis@gmail.com \
    --cc=thomas.de_schampheleire@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox