Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/{python, python3}: add mechanism to exclude .py files from removal
Date: Fri, 29 Nov 2019 08:52:02 +0100	[thread overview]
Message-ID: <87blsvf7bx.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20191127203404.291090-2-thomas.petazzoni@bootlin.com> (Thomas Petazzoni's message of "Wed, 27 Nov 2019 21:34:03 +0100")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > When BR2_PACKAGE_PYTHON{,3}_PYC_ONLY=y, we force remove all .py files
 > from the system, as they have all been byte-compiled into their .pyc
 > variants.

 > However, it turns out that some packages (e.g: OpenCV) do some funky
 > things with a few .py files: they pass them through Python's
 > execfile() facility, which only works with .py files and not .pyc
 > files. It is used by OpenCV for example to read two small
 > configuration files.

 > In order to support such use cases, this commit introduces a very
 > simple mechanism by which packages can exclude some path patterns from
 > the .py removal. The mechanism is a simple global
 > PYTHON{,3}_KEEP_PY_FILES, that packages can append to.

 > This is necessary to be able to fix bug #12171.

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
 > ---
 > Due to this only being needed by OpenCV for now, I didn't think it was
 > really needed to have a per-package variable, which then gets
 > collected by the generic-package infrastructure into a global
 > variable. We can always revisit if this gets more widely.

I agree, but this does cause a check-package warning from opencv3.mk:

package/opencv3/opencv3.mk:331: possible typo: PYTHON_KEEP_PY_FILES -> *OPENCV3*
package/opencv3/opencv3.mk:343: possible typo: PYTHON3_KEEP_PY_FILES -> *OPENCV3*

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2019-11-29  7:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-27 20:34 [Buildroot] [PATCH 0/2] Fix the OpenCV Python module Thomas Petazzoni
2019-11-27 20:34 ` [Buildroot] [PATCH 1/2] package/{python, python3}: add mechanism to exclude .py files from removal Thomas Petazzoni
2019-11-29  7:52   ` Peter Korsgaard [this message]
2019-11-29  7:56     ` Thomas Petazzoni
2019-11-29  9:13       ` Peter Korsgaard
2019-11-29  9:39         ` Thomas Petazzoni
2019-11-29  9:47           ` Peter Korsgaard
2019-11-27 20:34 ` [Buildroot] [PATCH 2/2] package/opencv3: ensure the python module works when BR2_PACKAGE_PYTHON{, 3}_PYC_ONLY=y Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blsvf7bx.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox