From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mario Lang Date: Mon, 08 Oct 2018 12:09:56 +0200 Subject: [Buildroot] [PATCH 1/1] brltty: fix build on mips64el In-Reply-To: (Fabrice Fontaine's message of "Mon, 8 Oct 2018 10:29:58 +0200") References: <20180930183408.4248-1-fontaine.fabrice@gmail.com> <87bm84g8cf.fsf@home.blind.guru> Message-ID: <87bm84eoln.fsf@home.blind.guru> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Fabrice Fontaine writes: > Dear Mario, > Le lun. 8 oct. 2018 ? 10:18, Mario Lang a ?crit : > >> Hi. >> >> Fabrice Fontaine writes: >> >> > Bump to version 5.6 has reintroduced the issue fixed by patch 854093 on >> > version 5.5. >> > >> > Indeed, third patch was merged upstream but it was then reverted: >> > >> https://github.com/brltty/brltty/commit/9e7d62c869d3c1cbe12dda8b0291a4692c193416 >> > >> > Moreover, since commit 3a2e3f6fa5ef0a210ffeba5ed05c79965d0cc3c7, MKOBJ >> > was renamed into MKREL. So, instead of patching again brltty, overwrite >> > LD to set the correct emulation depending on MIPS architecture as >> > already done in linux-tool-perf.mk.in. >> >> Thanks Fabrice. ack and +1. >> > Thanks for your review, however after the feedback from Arnout on first > patch iteration (https://patchwork.ozlabs.org/patch/972614/), I've also > sent a PR to brltty: https://github.com/brltty/brltty/pull/149. > Both solutions seems good to me. As I have mentioned previously in this thread, switching to GCC unconditionally break compilation on OS X. So PR 149 is likely not to be accepted. IMO, the right way forward is to commit your patch to buildroot, as it fixes a problem specific to mips. -- CYa, ?????