Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libcurl: fix build with ssh2 and static mbedtls
Date: Sun, 27 May 2018 23:42:04 +0200	[thread overview]
Message-ID: <87bmd0n5cj.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20180521114108.20916-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Mon, 21 May 2018 13:41:08 +0200")

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > The ssh2 pkg-config file could contain the following lines when build
 > with a static version of mbedtls:
 >    Libs: -L${libdir} -lssh2 /xxx/libmbedcrypto.a
 >    Libs.private: /xxx/libmbedcrypto.a

 > This static mbedtls library must be used to correctly detect ssh2
 > support and this library must be copied in libcurl.pc otherwise
 > compilation of any application (such as upmpdcli) with libcurl will fail
 > when trying to found mbedtls functions included in libssh2.
 > So, replace pkg-config --libs-only-l by pkg-config --libs.

 > Fixes:
 >  - http://autobuild.buildroot.net/results/43e24b22a77f616d6198c10435dcc23cc3b9088a

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed, thanks. Please submit the patch upstream.

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2018-05-27 21:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-21 11:41 [Buildroot] [PATCH 1/1] libcurl: fix build with ssh2 and static mbedtls Fabrice Fontaine
2018-05-22 21:06 ` Thomas Petazzoni
2018-05-22 21:43   ` Fabrice Fontaine
2018-05-23  6:02     ` Thomas Petazzoni
2018-05-27 21:42 ` Peter Korsgaard [this message]
2018-06-17 14:57 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bmd0n5cj.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox