From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/pkg-golang: use 'build' instead of 'install'
Date: Sun, 01 Apr 2018 16:35:47 +0200 [thread overview]
Message-ID: <87bmf3ro3g.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <14f910b9-da10-954d-2d40-13e4b6237b99@mind.be> (Arnout Vandecappelle's message of "Sun, 1 Apr 2018 14:26:47 +0200")
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
> Minor nit...
> On 01-04-18 13:51, Thomas Petazzoni wrote:
>> @@ -102,7 +102,9 @@ define $(2)_BUILD_CMDS
>> $$(GO_TARGET_ENV) \
>> GOPATH="$$(@D)/$$($(2)_WORKSPACE)" \
>> $$($(2)_GO_ENV) \
>> - $$(GO_BIN) install -v $$($(2)_BUILD_OPTS) ./$$(d)
>> + $$(GO_BIN) build -v $$($(2)_BUILD_OPTS) \
>> + -o $$(@D)/$$($(2)_BINDIR)/$$(if $$($(2)_BIN_NAME),$$($(2)_BIN_NAME),$$(notdir $$(d))) \
> I find the $(or ...) construct to be more readable:
> -o $$(@D)/$$($(2)_BINDIR)/$$(or $$($(2)_BIN_NAME),$$(notdir $$(d))) \
We do use a lot more $(if than $(or, but OK - $(or is shorter.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2018-04-01 14:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-01 11:51 [Buildroot] [PATCH 1/2] package/pkg-golang: use 'build' instead of 'install' Thomas Petazzoni
2018-04-01 11:51 ` [Buildroot] [PATCH 2/2] package/pkg-golang: drop the fixed <pkg>_BINDIR variable Thomas Petazzoni
2018-04-01 12:27 ` Yann E. MORIN
2018-04-01 14:42 ` Peter Korsgaard
2018-04-01 12:25 ` [Buildroot] [PATCH 1/2] package/pkg-golang: use 'build' instead of 'install' Yann E. MORIN
2018-04-01 12:26 ` Arnout Vandecappelle
2018-04-01 14:35 ` Peter Korsgaard [this message]
2018-04-01 14:36 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmf3ro3g.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox