From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] core/download: fix source check for git method
Date: Mon, 15 May 2017 14:09:28 +0200 [thread overview]
Message-ID: <87bmquiao7.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20170512155429.26176-1-yann.morin.1998@free.fr> (Yann E. MORIN's message of "Fri, 12 May 2017 17:54:29 +0200")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Running foo-source-check on packages retrieved from git fails.
> This is because there is no associated stamp file, so we do not have a
> rule-assignment that sets PKG for foo-source-check.
> But it does not make sense to have a stamp file at all, because
> source-check is not supposed to change anything: the status after is
> exactly the same as before; nothing is downlaoded, so there is no
> progress (whatsoever) to memorise.
> Fix that by just defining PKG in the source-check rule definition.
> Fixes #9796.
> Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Committed to 2017.02.x, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2017-05-15 12:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 15:54 [Buildroot] [PATCH] core/download: fix source check for git method Yann E. MORIN
2017-05-13 13:14 ` Thomas Petazzoni
2017-05-15 12:09 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmquiao7.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox