Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] e2fsprogs: bump to version 1.42.10
Date: Wed, 04 Jun 2014 00:19:53 +0200	[thread overview]
Message-ID: <87bnu9r5yu.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1401833214-31074-1-git-send-email-gustavo@zacarias.com.ar> (Gustavo Zacarias's message of "Tue, 3 Jun 2014 19:06:54 -0300")

>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:

 > Drop --disable-tls since it's not needed.
 > Add --disable-rpath to avoid unnecessary pollution.

 > e4defrag now needs an (e)glibc toolchain because of sync_file_range()
 > See e2fsprogs commit 58229aaf85d435469e901c974f31ead6d9124166

 > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
 > ---
 >  package/e2fsprogs/Config.in                        |  4 +++
 >  ..._CFLAGS-add-includes-when-cross-compiling.patch | 29 ++++++++++++++++++++++
 >  package/e2fsprogs/e2fsprogs.mk                     |  8 +++---
 >  3 files changed, 38 insertions(+), 3 deletions(-)
 >  create mode 100644 package/e2fsprogs/e2fsprogs-0002-BUILD_CFLAGS-add-includes-when-cross-compiling.patch

 > diff --git a/package/e2fsprogs/Config.in b/package/e2fsprogs/Config.in
 > index eb7bedb..1400f49 100644
 > --- a/package/e2fsprogs/Config.in
 > +++ b/package/e2fsprogs/Config.in
 > @@ -51,6 +51,10 @@ config BR2_PACKAGE_E2FSPROGS_E2UNDO
 >  config BR2_PACKAGE_E2FSPROGS_E4DEFRAG
 >  	bool "e4defrag"
 >  	depends on !BR2_avr32 && !BR2_nios2 # fallocate not implemented
 > +	depends on !BR2_TOOLCHAIN_USES_UCLIBC # sync_file_range not impl
 > +
 > +comment "e4defrag needs an (e)glibc toolchain"
 > +	depends on BR2_TOOLCHAIN_USES_UCLIBC

What about musl? To match the comment we should use
!BR2_TOOLCHAIN_USES_GLIBC instead.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2014-06-03 22:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-03 22:06 [Buildroot] [PATCH] e2fsprogs: bump to version 1.42.10 Gustavo Zacarias
2014-06-03 22:19 ` Peter Korsgaard [this message]
2014-06-03 22:21   ` Gustavo Zacarias
2014-06-04  6:52 ` Thomas Petazzoni
2014-06-04  7:44   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bnu9r5yu.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox