From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] A Bug: xserver_xorg 1.12.4
Date: Wed, 11 Sep 2013 12:52:58 +0200 [thread overview]
Message-ID: <87bo3ztyt1.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20130911111732.3300eaa7@skate> (Thomas Petazzoni's message of "Wed, 11 Sep 2013 11:17:32 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Thomas> Dear Woody Wu,
Thomas> On Mon, 9 Sep 2013 16:04:33 +0800, Woody Wu wrote:
>> In 2013.08, build is using 1.12.4 version of xserver_xorg package.
>> However, I found there is bug in this version, which cause the options
>> parsing of kdrive modules is not correct.
>>
>> I attached a patch file in the message (not sure what's the correct way
>> to commit buildroot package patches).
Thomas> Unfortunately, no, it's not the correct. You should submit a patch
Thomas> against Buildroot, which adds a patch in
Thomas> package/x11r7/xserver_xorg-server/ that fixes the bug you're seeing.
Thomas> See http://buildroot.org/downloads/manual/manual.html#patch-policy.
Thomas> Also, it'd be good to see if this patch has been fixed upstream
Thomas> already. If it's already fixed upstream, either backport the upstream
Thomas> patch, or bump the X.org server version used in Buildroot. If not, then
Thomas> try to submit your patch upstream so that it gets integrated in future
Thomas> releases of X.org.
It is fixed upstream, but it was never pushed to the 1.12 branch:
http://cgit.freedesktop.org/xorg/xserver/commit/hw/kdrive/src/kinput.c?id=09f1e5b15b769e1122f0a8d7
I've cherry picked it and added it to buildroot, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2013-09-11 10:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 8:04 [Buildroot] A Bug: xserver_xorg 1.12.4 Woody Wu
2013-09-11 9:17 ` Thomas Petazzoni
2013-09-11 10:52 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bo3ztyt1.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox