Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] stress: honor the BR2_PREFER_STATIC_LIB preference
Date: Mon, 04 Mar 2013 17:15:01 +0100	[thread overview]
Message-ID: <87boazb0qi.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <CAEvN+1hHaUvusQPDV8qbs8ipzx-m0+Vhe02FmeWZp9NMrPYJ=A@mail.gmail.com> (Tzu-Jung Lee's message of "Mon, 4 Mar 2013 02:55:59 +0800")

>>>>> "T" == Tzu-Jung Lee <roylee17@gmail.com> writes:

 T> ? ? ifeq ($(BR2_PREFER_STATIC_LIB),y)
 T> ? ? SHARED_STATIC_LIBS_OPTS=--enable-static --disable-shared
 T> ? ? TARGET_LDFLAGS += --static
 T> ? ? else
 T> ? ? SHARED_STATIC_LIBS_OPTS=--enable-static --enable-shared
 T> ? ? endif

 T> As you indicated, the --enable-static is given anyway in the
 T> SHARED_STATIC_LIBS_OPTS.  Unfortunately, as long as the
 T> --enable-static is given, stress links the program statically,
 T> regardless how the --enable-shared or --disable-shared.  In this
 T> case, stress would be linked statically regardless how the
 T> BR2_PREFER_STATIC_LIB specifies.  So we need the patch to explicitly
 T> tell it link the program dynamically by appending/overriding with
 T> --disable-static.

So you only need to pass --disable-static if !BR2_PREFER_STATIC_LIB?
Could you please resend with a patch only doing that and a comment above
it explaining why?

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2013-03-04 16:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-02  6:35 [Buildroot] [PATCH] stress: honor the BR2_PREFER_STATIC_LIB preference Tzu-Jung Lee
2013-03-03 16:51 ` Arnout Vandecappelle
2013-03-03 18:55   ` Tzu-Jung Lee
2013-03-04 16:15     ` Peter Korsgaard [this message]
2013-03-04 17:50       ` Tzu-Jung Lee
2013-03-04 17:47 ` Tzu-Jung Lee
2013-03-04 19:59   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87boazb0qi.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox