From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [pull request] Pull request for branch for-2011.11/pkg-infra
Date: Fri, 28 Oct 2011 16:08:32 +0200 [thread overview]
Message-ID: <87bot1p5sv.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20110930163236.12055d01@skate> (Thomas Petazzoni's message of "Fri, 30 Sep 2011 16:32:36 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Sorry, old mail ..
>> From that perspective, I only provided comments to your patches when I
>> had some. Up until now, I have not really acked any of your patches on
>> which I had no comments but otherwise though were good. This for the
>> simple reason that I didn't think it would change anything about the
>> chances of your patches being merged, given my expectation that Peter
>> would 'trust' your changes and take them in.
Thomas> Peter will hopefully comment on this, but I think having your
Thomas> Ack on others patches would be very useful. The more Acks there
Thomas> are on a given patch, the less time Peter will spend reviewing
Thomas> the patch, especially when those Acks come from people that
Thomas> have shown in the past to have a very good understanding of the
Thomas> Buildroot internals (which definitely is your case, considering
Thomas> the type of patches you have been sending recently).
Yes, definately. Naturally, an ack by old timers have a bit more weight
than people I don't know, but it definately is useful to know if other
people have looked over a patch and/or tried it.
I agree with all the rest of Thomas' (P) mail.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2011-10-28 14:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 19:57 [Buildroot] [pull request] Pull request for branch for-2011.11/pkg-infra Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 01/15] package: enhance infrastructure to support source dir override Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 02/15] package: add configuration option to specify a local override file Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 03/15] package: add <pkg>-rebuild and <pkg>-reconfigure Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 04/15] package: implement a 'local' site method Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 05/15] package: add helper functions to get package name and directory magically Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 06/15] package: remove useless arguments from GENTARGETS Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 07/15] package: remove useless arguments from AUTOTARGETS Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 08/15] package: remove useless arguments from CMAKETARGETS Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 09/15] Makefile.package.in: Pass non-prefixed name as argument to GENTARGETS_INNER Thomas Petazzoni
2011-09-30 6:31 ` Peter Korsgaard
2011-09-29 19:57 ` [Buildroot] [PATCH 10/15] Add support for local packages through 'file://' pseudo-protocol Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 11/15] fakeroot: remove target package Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 12/15] dhrystone: use the <pkg>_EXTRACT_CMDS mechanism Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 13/15] whetstone: " Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 14/15] mcookie: convert to the GENTARGETS infrastructure Thomas Petazzoni
2011-09-29 19:57 ` [Buildroot] [PATCH 15/15] package: normalize output of 'make external-deps' Thomas Petazzoni
2011-09-29 21:37 ` [Buildroot] [pull request] Pull request for branch for-2011.11/pkg-infra Peter Korsgaard
2011-09-30 4:51 ` Thomas Petazzoni
2011-09-30 6:29 ` Peter Korsgaard
2011-09-30 6:33 ` Thomas Petazzoni
2011-09-30 6:41 ` Peter Korsgaard
2011-09-29 21:47 ` Yann E. MORIN
2011-09-30 7:48 ` Thomas De Schampheleire
2011-09-30 8:03 ` Yann E. MORIN
2011-09-30 13:53 ` Thomas De Schampheleire
2011-09-30 14:32 ` Thomas Petazzoni
2011-10-28 14:08 ` Peter Korsgaard [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-09-19 20:53 Thomas Petazzoni
2011-08-31 21:29 Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bot1p5sv.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox