From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 02/10] ext-toolchain: Fix ARCH_SYSROOT detection
Date: Mon, 28 Jun 2010 13:09:07 +0200 [thread overview]
Message-ID: <87bpav2z3g.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <bf1bcc24c829475c10cf9304df7f3515f21d937f.1276516273.git.thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Mon, 14 Jun 2010 13:54:13 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Hi,
Thomas> For the detection of the ARCH_SYSROOT_DIR (which contains the C
Thomas> library variant specific to the compiler flags), we used to
Thomas> pass only the -march argument instead of the full
Thomas> TARGET_CFLAGS. This was done because TARGET_CFLAGS contains
Thomas> --sysroot, and we don't want to tell here the compiler which
Thomas> sysroot to use, because we're specifically asking the compiler
Thomas> where the *normal* arch sysroot directory is.
Thomas> Unfortunately, there are some multilib variants that aren't
Thomas> decided only based on -march, but also on -msoft-float or other
Thomas> compiler flags. Therefore, we take the opposite approach: pass
Thomas> the full TARGET_CFLAGS, from which we have stripped the
Thomas> --sysroot option.
[snip]
Thomas> +TARGET_CFLAGS_NO_SYSROOT=$(filter-out --sysroot=%,$(TARGET_CFLAGS))
Hmm, in package/Makefile.in I see:
else ifeq ($(BR2_TOOLCHAIN_EXTERNAL),y)
TARGET_CFLAGS+=--sysroot $(STAGING_DIR)/
TARGET_CXXFLAGS=$(TARGET_CFLAGS)
E.G. no = between --sysroot and the value.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2010-06-28 11:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-14 11:54 [Buildroot] [pull request] Pull request for branch ext-toolchain-fixes Thomas Petazzoni
2010-06-14 11:54 ` [Buildroot] [PATCH 01/10] ext-toolchains: take into account other Glibc dynamic loader variants Thomas Petazzoni
2010-06-14 19:50 ` Yann E. MORIN
2010-06-14 11:54 ` [Buildroot] [PATCH 02/10] ext-toolchain: Fix ARCH_SYSROOT detection Thomas Petazzoni
2010-06-14 19:54 ` Yann E. MORIN
2010-06-28 11:09 ` Peter Korsgaard [this message]
2010-06-14 11:54 ` [Buildroot] [PATCH 03/10] external-toolchain: only copy existing directories of the sysroot Thomas Petazzoni
2010-06-14 19:56 ` Yann E. MORIN
2010-06-14 11:54 ` [Buildroot] [PATCH 04/10] external-toolchain: support 64 bits glibc toolchains Thomas Petazzoni
2010-06-14 20:07 ` Yann E. MORIN
2010-06-14 20:59 ` Thomas Petazzoni
2010-06-14 21:06 ` Yann E. MORIN
2010-06-14 11:54 ` [Buildroot] [PATCH 05/10] external-toolchain: create lib64 symlinks if needed Thomas Petazzoni
2010-06-14 21:11 ` Yann E. MORIN
2010-06-14 11:54 ` [Buildroot] [PATCH 06/10] external-toolchain: mention MIPS and PowerPC CodeSourcery toolchains Thomas Petazzoni
2010-06-14 11:54 ` [Buildroot] [PATCH 07/10] external-toolchain: recognize uClibc 64 bits toolchains Thomas Petazzoni
2010-06-14 11:54 ` [Buildroot] [PATCH 08/10] uclibc: add patch to fix fcntl64() on 64 bits targets Thomas Petazzoni
2010-06-14 11:54 ` [Buildroot] [PATCH 09/10] external-toolchain: handle libstdc++/libgcc_s for BR toolchains Thomas Petazzoni
2010-06-14 11:54 ` [Buildroot] [PATCH 10/10] external-toolchain: hardcode the destination directory for a library Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2010-07-05 16:58 [Buildroot] [pull request] Pull request for branch ext-toolchain-fixes Thomas Petazzoni
2010-07-05 16:58 ` [Buildroot] [PATCH 02/10] ext-toolchain: Fix ARCH_SYSROOT detection Thomas Petazzoni
2010-07-05 19:27 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bpav2z3g.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox