From: Peter Korsgaard <peter@korsgaard.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Titouan Christophe <titouanchristophe@gmail.com>,
Daniel Price <daniel.price@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/redis: disable -Werror
Date: Mon, 18 Mar 2024 14:31:09 +0100 [thread overview]
Message-ID: <87cyrrfyzm.fsf@48ers.dk> (raw)
In-Reply-To: <20240301183349.808102-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Fri, 1 Mar 2024 19:33:49 +0100")
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Disable -Werror to avoid the following build failure raised since bump
> to version 7.2.1 in commit d49f53f8aaf0bff9c8d04c16485c844fef2832d0 and
> https://github.com/redis/redis/commit/8e138ba44fc3eb676c0f31faac19d1acc6a4c7ed:
> In function 'hi_sdsll2str',
> inlined from 'hi_sdsfromlonglong' at sds.c:500:15:
> sds.c:457:12: error: writing 1 byte into a region of size 0 [-Werror=stringop-overflow=]
> 457 | *s = *p;
> | ~~~^~~~
> Fixes: d49f53f8aaf0bff9c8d04c16485c844fef2832d0
> - http://autobuild.buildroot.org/results/fdc9f940b348430cb4da8efecc5cc047b21df281
> - http://autobuild.buildroot.org/results/e5747674d52b065203a0442f7cab13e8be5f426b
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2023.11.x, thanks.
> ---
> package/redis/redis.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/package/redis/redis.mk b/package/redis/redis.mk
> index 09a3b9448b..2680b11b74 100644
> --- a/package/redis/redis.mk
> +++ b/package/redis/redis.mk
> @@ -30,7 +30,7 @@ endif
> # https://github.com/antirez/redis/pull/609). We set PREFIX
> # instead.
> REDIS_BUILDOPTS = $(TARGET_CONFIGURE_OPTS) \
> - PREFIX=$(TARGET_DIR)/usr MALLOC=libc
> + PREFIX=$(TARGET_DIR)/usr MALLOC=libc WARNINGS=
> ifeq ($(BR2_PACKAGE_SYSTEMD),y)
> REDIS_DEPENDENCIES += systemd
> --
> 2.43.0
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-03-18 13:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 18:33 [Buildroot] [PATCH 1/1] package/redis: disable -Werror Fabrice Fontaine
2024-03-01 18:54 ` Peter Korsgaard
2024-03-18 13:31 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyrrfyzm.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=daniel.price@gmail.com \
--cc=fontaine.fabrice@gmail.com \
--cc=titouanchristophe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox