Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Jean Burgat <jeanburgat33@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/openfpgaloader: bump to version 0.11.0
Date: Thu, 30 Nov 2023 22:16:32 +0100	[thread overview]
Message-ID: <87cyvr7xhr.fsf@48ers.dk> (raw)
In-Reply-To: <20231129220843.1712894-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Wed, 29 Nov 2023 23:08:43 +0100")

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > This bump will fix the following build failure thanks to
 > https://github.com/trabucayre/openFPGALoader/commit/933ed793e85dea7e16ddd6540791097fd3a299f5:

Hmm, but that commit is about adding support for libgpiod v2.x, and we
use v1.6.x?

Probably it is only the missing #include <cstdint> that fixes it. I gave
it a try here, but there were unfortunately a number of other files also
missing it so ended up applying it after all.

Committed, thanks.

Interesting enough I cannot reproduce the build issue with 2023.08.x, so
presumably it is related to the libgpiod 1.6.4 bump.


 > In file included from /home/buildroot/autobuild/instance-3/output-1/build/openfpgaloader-0.10.0/src/jtag.hpp:13,
 >                  from /home/buildroot/autobuild/instance-3/output-1/build/openfpgaloader-0.10.0/src/device.hpp:13,
 >                  from /home/buildroot/autobuild/instance-3/output-1/build/openfpgaloader-0.10.0/src/efinix.hpp:11,
 >                  from /home/buildroot/autobuild/instance-3/output-1/build/openfpgaloader-0.10.0/src/efinix.cpp:6:
 > /home/buildroot/autobuild/instance-3/output-1/build/openfpgaloader-0.10.0/src/board.hpp:49:9: error: 'uint8_t' does not name a type
 >    49 |         uint8_t tms_pin; /*! TMS pin value */
 >       |         ^~~~~~~
 > /home/buildroot/autobuild/instance-3/output-1/build/openfpgaloader-0.10.0/src/board.hpp:12:1: note: 'uint8_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
 >    11 | #include "cable.hpp"
 >   +++ |+#include <cstdint>
 >    12 |

 > https://github.com/trabucayre/openFPGALoader/releases/tag/v0.11.0

 > Fixes:
 >  - http://autobuild.buildroot.org/results/ee89dcc7430079195e2e9ff300e1320de848d3e3

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 > ---
 >  package/openfpgaloader/openfpgaloader.hash | 2 +-
 >  package/openfpgaloader/openfpgaloader.mk   | 2 +-
 >  2 files changed, 2 insertions(+), 2 deletions(-)

 > diff --git a/package/openfpgaloader/openfpgaloader.hash b/package/openfpgaloader/openfpgaloader.hash
 > index a8b537782c..6fa81a98a2 100644
 > --- a/package/openfpgaloader/openfpgaloader.hash
 > +++ b/package/openfpgaloader/openfpgaloader.hash
 > @@ -1,3 +1,3 @@
 >  # Locally computed
 > -sha256  966b4629df86b1d520ddd8a4e0a3fc00060b26b5ab4e172b596bd9d4659a196e  openfpgaloader-0.10.0.tar.gz
 > +sha256  a463690358d2510919472c2f460039a304d016a08a45970821e667eea1c48cc8  openfpgaloader-0.11.0.tar.gz
 >  sha256  c71d239df91726fc519c6eb72d318ec65820627232b2f796219e87dcf35d0ab4  LICENSE
 > diff --git a/package/openfpgaloader/openfpgaloader.mk b/package/openfpgaloader/openfpgaloader.mk
 > index 6d7fbd9850..0fd172b532 100644
 > --- a/package/openfpgaloader/openfpgaloader.mk
 > +++ b/package/openfpgaloader/openfpgaloader.mk
 > @@ -4,7 +4,7 @@
 >  #
 >  ################################################################################
 
 > -OPENFPGALOADER_VERSION = 0.10.0
 > +OPENFPGALOADER_VERSION = 0.11.0
 >  OPENFPGALOADER_SITE = $(call github,trabucayre,openFPGALoader,v$(OPENFPGALOADER_VERSION))
 >  OPENFPGALOADER_LICENSE = Apache-2.0
 >  OPENFPGALOADER_LICENSE_FILES = LICENSE
 > -- 

 > 2.42.0

 > _______________________________________________
 > buildroot mailing list
 > buildroot@buildroot.org
 > https://lists.buildroot.org/mailman/listinfo/buildroot


-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2023-11-30 21:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-29 22:08 [Buildroot] [PATCH 1/1] package/openfpgaloader: bump to version 0.11.0 Fabrice Fontaine
2023-11-30 21:16 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cyvr7xhr.fsf@48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=jeanburgat33@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox