From: Peter Korsgaard <peter@korsgaard.com>
To: Nicolas Boichat via buildroot <buildroot@buildroot.org>
Cc: Nicolas Boichat <drinkcat@google.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [PATCH v3 1/1] package/screenfetch: Add upstream awk detection patch.
Date: Tue, 12 Sep 2023 08:06:34 +0200 [thread overview]
Message-ID: <87cyyo7wnp.fsf@48ers.dk> (raw)
In-Reply-To: <20230812010118.2654653-1-drinkcat@google.com> (Nicolas Boichat via buildroot's message of "Sat, 12 Aug 2023 01:01:17 +0000")
>>>>> "Nicolas" == Nicolas Boichat via buildroot <buildroot@buildroot.org> writes:
> screenfetch requires an "awk" implementation, but upstream would
> only use an executable called "awk": pick up upstream patch that
> can autodetect awk implementation, so that "mawk" can be used.
> Signed-off-by: Nicolas Boichat <drinkcat@google.com>
> ---
> Changes v2 -> v3:
> - Simply assume that an awk implementation is provided [Arnout Vandecappelle]
> Changes v1 -> v2:
> - Busybox's awk also works, so add that as a possible dependency [Thomas Petazzoni]
> - Tried to use "select" instead of "depends" as suggested, but that
> creates a circular dependency.
> - Fixed boolean logic in "comment" part (&& not ||)
> .../0001-Detect-which-awk-to-use.patch | 783 ++++++++++++++++++
> 1 file changed, 783 insertions(+)
> create mode 100644 package/screenfetch/0001-Detect-which-awk-to-use.patch
Committed to 2023.02.x and 2023.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-09-12 6:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-12 1:01 [Buildroot] [PATCH v3 1/1] package/screenfetch: Add upstream awk detection patch Nicolas Boichat via buildroot
2023-08-12 10:48 ` Thomas Petazzoni via buildroot
2023-09-12 6:06 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyyo7wnp.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=drinkcat@google.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox