From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F298C7EE43 for ; Tue, 6 Jun 2023 20:22:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 9C416612EB; Tue, 6 Jun 2023 20:22:38 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 9C416612EB X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qCOeTsfIMjD2; Tue, 6 Jun 2023 20:22:37 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id AE581612D1; Tue, 6 Jun 2023 20:22:36 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org AE581612D1 Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 386521BF3EF for ; Tue, 6 Jun 2023 20:22:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 111DB4012C for ; Tue, 6 Jun 2023 20:22:35 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 111DB4012C X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mPqjJd2H5N6q for ; Tue, 6 Jun 2023 20:22:33 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org CADB141B31 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::226]) by smtp4.osuosl.org (Postfix) with ESMTPS id CADB141B31 for ; Tue, 6 Jun 2023 20:22:32 +0000 (UTC) X-GND-Sasl: peter@korsgaard.com X-GND-Sasl: peter@korsgaard.com X-GND-Sasl: peter@korsgaard.com X-GND-Sasl: peter@korsgaard.com X-GND-Sasl: peter@korsgaard.com X-GND-Sasl: peter@korsgaard.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 808E0C0004; Tue, 6 Jun 2023 20:22:30 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.94.2) (envelope-from ) id 1q6dCH-00F3I8-HF; Tue, 06 Jun 2023 22:22:29 +0200 From: Peter Korsgaard To: Romain Naour References: <20230605095607.332091-1-romain.naour@gmail.com> Date: Tue, 06 Jun 2023 22:22:27 +0200 In-Reply-To: <20230605095607.332091-1-romain.naour@gmail.com> (Romain Naour's message of "Mon, 5 Jun 2023 11:56:06 +0200") Message-ID: <87cz2849z0.fsf@48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Subject: Re: [Buildroot] [PATCH 1/2] support/dependencies: introduce BR2_HOST_CMAKE_AT_LEAST X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Julien Olivain , "Yann E . MORIN" , Thomas Petazzoni , buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" >>>>> "Romain" == Romain Naour writes: > Some packages (e.g. libjxl) requires a quite recent cmake version, > that is not yet available in most distributions, especially those > LTS versions. > Currently, when we bump the minum cmake version we require, it gets > bumped for all packages, regardless of their own minimum required > version, which means that a given configuration will trigger the > build of our host-cmake even if the packages that require it are not > enabled and those that are would be content with the system-provided > cmake. > Since host-cmake can take quite some time to build, this can get a > bit annoying to pay the price of a host-cmake build that would > otherwise not be needed. > Some packages even use an alternative build system when available > since they requires a more recent version of cmake than the our > minum cmake version > (wpewebkit use Ninja: 78d499409f71d8a22b0632c8ebc06f67ee6ae6dd). > We introduce config options that packages can select to indicate > what minimal cmake version they require, and use that version as the > required minimal version required by the current configuration [0]. > We would like to ensure that the currently selected minimum cmake > version is indeed lower (or equal) to the cmake version we package, > but that is not possible: dependencies.mk is parsed before we parse > packages, so we do not yet know the cmake version we have, and we > can't invert the parsing order as we need to know the requires > dependencies before we parse packages (so that we can build their > dependency rules in Makefile). So we can only add comments in both > places, that refer to the other location. > [0] note that this is yet not optimal, as in such a case, host-cmake > would be in the dependency chain of all cmake-based packages, even > for those packages that do not require it. The optimum would be for > each package to gain such a dependency on an as-needed basis, but > this is by far more complex to achieve, and would only speed up > cases where a single package is built from scratch (e.g. with: > make clean; make foo), which is not worth optimising (yet?) > Signed-off-by: Romain Naour > Cc: Julien Olivain > Cc: Arnout Vandecappelle > Cc: Peter Korsgaard > Cc: Yann E. MORIN > Cc: Thomas Petazzoni > --- > v2: Use the commit log suggested by Yann > http://lists.busybox.net/pipermail/buildroot/2023-June/668312.html Committed, thanks. -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot