From: Peter Korsgaard <peter@korsgaard.com>
To: Thomas Devoogdt <thomas@devoogdt.com>
Cc: Thomas Devoogdt <thomas.devoogdt@barco.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/4] package/fluent-bit: fix luajit support
Date: Fri, 12 May 2023 20:58:35 +0200 [thread overview]
Message-ID: <87cz352x7o.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20230327141058.3669326-2-thomas.devoogdt@barco.com> (Thomas Devoogdt's message of "Mon, 27 Mar 2023 16:10:56 +0200")
>>>>> "Thomas" == Thomas Devoogdt <thomas@devoogdt.com> writes:
> Fluent-bit doesn't link against any libraries,
> it just compiles everything as static sources,
> meaning that our buildroot BR2_PACKAGE_LUAJIT isn't
> the right check.
> The same -m32 fix as in the luajit package can't be done,
> since fluent-bit uses a custom cmake wrapper. So just check if the
> host and the target have the same number of bits.
> My intention here is to fix upstream build errors,
> not perse to have luajit support in fluent-bit.
> Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
Hmm, would it instead be possible to use an external luajit so we
wouldn't have this problem in the first place?
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-05-12 18:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 14:10 [Buildroot] [PATCH 1/4] package/fluent-bit: bump to version 2.0.10 Thomas Devoogdt
2023-03-27 14:10 ` [Buildroot] [PATCH 2/4] package/fluent-bit: fix luajit support Thomas Devoogdt
2023-05-12 18:58 ` Peter Korsgaard [this message]
2023-05-13 5:49 ` Thomas Devoogdt
2023-03-27 14:10 ` [Buildroot] [PATCH 3/4] package/fluent-bit: fix wasm uClibc support Thomas Devoogdt
2023-03-27 14:10 ` [Buildroot] [PATCH 4/4] package/fluent-bit: drop xtensa from wasm-micro-runtime Thomas Devoogdt
2023-05-12 18:56 ` [Buildroot] [PATCH 1/4] package/fluent-bit: bump to version 2.0.10 Peter Korsgaard
2023-06-13 6:37 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz352x7o.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=thomas.devoogdt@barco.com \
--cc=thomas@devoogdt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox