From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/openvpn: set OPENVPN_CPE_ID_VENDOR
Date: Sat, 09 Jan 2021 22:18:04 +0100 [thread overview]
Message-ID: <87czydx10z.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20210109211424.11091067@windsurf.home> (Thomas Petazzoni's message of "Sat, 9 Jan 2021 21:14:24 +0100")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> On Sat, 09 Jan 2021 16:08:24 +0100
> Peter Korsgaard <peter@korsgaard.com> wrote:
>> > +OPENVPN_CPE_ID_VENDOR = $(OPENVPN_NAME)
>>
>> I am not sure why we do this obfuscation with the _NAME variable instead
>> of just "openvpn" - But ok, a bunch of other packages do so as well.
> Yes, it was done like this in the original patch from Matt, and I kept
> it as-is, but I also wasn't too sure about it. But since nobody
> complained when I posted the patch, I applied it as-is.
> I definitely wouldn't oppose to changing this to not use the
> <pkg>_NAME variable, as it find this indirection to not be very useful.
Ok, good. It may make sense to default _CPE_ID_VENDOR to $($(PKG)_NAME),
which is perhaps where this comes from?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2021-01-09 21:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 17:53 [Buildroot] [PATCH 1/1] package/openvpn: set OPENVPN_CPE_ID_VENDOR Fabrice Fontaine
2021-01-09 15:08 ` Peter Korsgaard
2021-01-09 20:14 ` Thomas Petazzoni
2021-01-09 21:18 ` Peter Korsgaard [this message]
2021-01-09 21:54 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czydx10z.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox