Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/dtc: needs host-pkgconf unconditionally
Date: Sat, 09 Nov 2019 18:48:08 +0100	[thread overview]
Message-ID: <87d0e1kkkn.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20191103104206.1061-1-yann.morin.1998@free.fr> (Yann E. MORIN's message of "Sun, 3 Nov 2019 11:42:06 +0100")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Commits 495e757d2 (package/dtc: add optional libyaml dependency) and
 > e43d9072a (package/dtc: fix build without libyaml), added a conditional
 > dependency to host-pkgconf, when libyaml is enabled, while commit
 > 56d6dd453 (package/dtc: disable valgrind) explicitly disabled support of
 > valgrind.

 > However, presence of libyaml, as well as that of valgrind, *is* detected
 > by calling pkg-config:

 >     NO_VALGRIND := $(shell $(PKG_CONFIG) --exists valgrind; echo $$?)
 >     NO_YAML := $(shell $(PKG_CONFIG) --exists yaml-0.1; echo $$?)

 > Passing NO_YAML=1 or NO_VALGRIND=1 do not prevent the tests from being
 > executed, which would yield messages like:

 >     /bin/sh: 1: /home/ymorin/dev/buildroot/O/host/bin/pkg-config: not found

 > (note however that, even if the test is executed, the value we pass on
 > the command line still takes precedence, and the support for either is
 > properly disabled.)

 > So, move the dependency on host-pkgconfig out of the condition. Ditto
 > for the host package.

 > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
 > Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 > Cc: Titouan Christophe <titouan.christophe@railnova.eu>
 > Cc: Carlos Santos <unixmania@gmail.com>

Committed to 2019.08.x, thanks.

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2019-11-09 17:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-03 10:42 [Buildroot] [PATCH] package/dtc: needs host-pkgconf unconditionally Yann E. MORIN
2019-11-08 20:59 ` Thomas Petazzoni
2019-11-09 17:48 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0e1kkkn.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox