From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2, 1/1] open-plc-utils: fix build with static musl
Date: Wed, 24 Oct 2018 13:10:38 +0200 [thread overview]
Message-ID: <87d0rzd2hd.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20181011182013.16467-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Thu, 11 Oct 2018 20:20:13 +0200")
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Pass TARGET_LDFLAGS to EXTRA_LDFLAGS to fix following issue:
> /home/buildroot/autobuild/run/instance-3/output/build/host-gcc-final-7.3.0/build/arm-buildroot-linux-musleabihf/libgcc/../../../libgcc/config/arm/lib1funcs.S:1545:
> undefined reference to `raise'
> Also pass TARGET_CFLAGS to EXTRA_CFLAGS and TARGET_CXXFLAGS to
> EXTRA_CXXFLAGS and move all these variables to
> OPEN_PLC_UTILS_MAKE_OPTS for readability
> Fixes:
> - http://autobuild.buildroot.org/results/67bc5e7ac8ae1c49c035b022a394d2f746705cf2
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Thomas Petazzoni):
> - Instead of passing -static to EXTRA_LDFLAGS, use TARGET_LDFLAGS
> - pass TARGET_CFLAGS to EXTRA_CFLAGS
> - pass TARGET_CXXFLAGS to EXTRA_CXXFLAGS
Committed to 2018.02.x and 2018.08.x, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2018-10-24 11:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 18:20 [Buildroot] [PATCH v2, 1/1] open-plc-utils: fix build with static musl Fabrice Fontaine
2018-10-11 18:57 ` Thomas Petazzoni
2018-10-24 11:10 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0rzd2hd.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox