From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] Fix issue with printvars executing giant shell command
Date: Fri, 05 Oct 2018 13:31:57 +0200 [thread overview]
Message-ID: <87d0so7hoy.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20180917181054.14616-1-tpiepho@impinj.com> (Trent Piepho's message of "Mon, 17 Sep 2018 11:10:54 -0700")
>>>>> "Trent" == Trent Piepho <tpiepho@impinj.com> writes:
> The underlying problem is that $(foreach V,1 2 3,) does not evaluate to
> an empty string. It evaluates to "? ", three empty strings separated by
> whitespace.
> A construct of this format, with a giant list in the foreach, is part of
> the printvars command. This means that "@:$(foreach ....)", which is
> intended to expand to a null command, in fact expands to "@: "
> with a great deal of whitespace. Make chooses to execute this command
> with:
> execve("/bin/sh", ["/bin/sh", "-c", ": "]
> But with far more whitespace. So much that it can exceed shell command
> line length limits.
> This solution is to move the foreach to another step in the recipe. The
> "@:" is retained as the first line so the recipe is not Empty, which
> would cause a change in make behavior when make builds the target. The
> 2nd line, all whitespace, will be skipped by make.
> Signed-off-by: Trent Piepho <tpiepho@impinj.com>
Committed to 2018.02.x, 2018.05.x and 2018.08.x, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2018-10-05 11:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 18:10 [Buildroot] [PATCH v2] Fix issue with printvars executing giant shell command Trent Piepho
2018-09-17 19:42 ` Yann E. MORIN
2018-09-18 20:12 ` Thomas Petazzoni
2018-10-05 11:31 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0so7hoy.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox