From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] systemd: Fix relative ln add-wants wrapper
Date: Tue, 27 Feb 2018 22:06:22 +0100 [thread overview]
Message-ID: <87d10qm9bl.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20180223201835.16143-1-tpiepho@impinj.com> (Trent Piepho's message of "Fri, 23 Feb 2018 12:18:35 -0800")
>>>>> "Trent" == Trent Piepho <tpiepho@impinj.com> writes:
> The patch to allow systemd to work with old "ln" versions that don't
> support --relative didn't work properly in the the meson-add-wants.sh
> script.
> This results in all the links in systemd's "*.wants" directories being
> broken, e.g.
> /usr/lib/systemd/system/multi-user.target.wants/getty.target ->
> ../../../../usr/lib/systemd/system/getty.target
> There is one too few ".." in that relative link.
> The problem is that the script is called with the link name being either a
> file or an existing directory. In the latter case, ln creates the link in
> the directory using the name of the target. This means the link is one
> level deeper than the relative link making code thinks.
> The solution used is to only dirname the link, moving up a level, if it's
> not a directory, to mimic ln's logic in how it creates links.
> Signed-off-by: Trent Piepho <tpiepho@impinj.com>
Committed, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2018-02-27 21:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 20:18 [Buildroot] [PATCH] systemd: Fix relative ln add-wants wrapper Trent Piepho
2018-02-27 21:01 ` Yann E. MORIN
2018-02-27 21:06 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d10qm9bl.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox