Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/bridge-utils: fix headers path
Date: Tue, 03 Oct 2017 14:39:19 +0200	[thread overview]
Message-ID: <87d164be2w.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20171002214009.13353-1-yann.morin.1998@free.fr> (Yann E. MORIN's message of "Mon, 2 Oct 2017 23:40:09 +0200")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Currently, bridge-utils wants to grap the headers from the linux-headers
 > package, so we point it directly there, as has been the case since we
 > first added bridge-utils in 2003 (c8eea31d3f), and then further refined
 > in 2005 (178a317d26) which is the first moment we pointed to the linux-
 > headers directory.

 > However, ther are two things wrong with that.

 > First, the headers are not directly in $(LINUX_HEADERS_DIR). Instead,
 > they are in a sub-directory thereof. So, we could not have found them
 > the way we are doing now.

 > Second, this definitely does not work when using an external toolchain,
 > because there is not linux-headers package enabled then.

 > Yet, against all odds, bridge-utils has valiantly deflected all rocks
 > thrown its way, day-in day-out building without any issue in every
 > autobuilders it's been confronted with. Good boy, good boy. :-)

Heh ;)

 > And indeed, it turns out that the required headers are easily found from
 > within the sysroot of the toolchain. Wonders! :-)

 > But there's still a gotcha: the default search path is still a hard
 > coded path pointing to oft installed kernel source tree on the host.

 > So, we still have to pass this option, but we can simply point to a
 > non-existent directory.

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

While this works I don't really like this does-not-exist. I've changed
it to use $(STAGING_DIR)/usr/include, tweaked the comment and committed,
thanks.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2017-10-03 12:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-02 21:40 [Buildroot] [PATCH] package/bridge-utils: fix headers path Yann E. MORIN
2017-10-03 12:39 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d164be2w.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox