Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] uclibc-ng: enable fts in default config file.
Date: Sat, 15 Jul 2017 17:15:51 +0200	[thread overview]
Message-ID: <87d191afyw.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20170715114432.0b01a373@windsurf> (Thomas Petazzoni's message of "Sat, 15 Jul 2017 11:44:32 +0200")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > Hello,
 > On Thu, 13 Jul 2017 10:25:48 -0400, Adam Duskett wrote:
 >> currently there are a few packages in buildroot that are set to not
 >> be selectable unless the user wishes to use glibc specifically because
 >> the package uses fts.h.
 >> 
 >> uClibc actually does have a fts implimentation, and it's selectable in
 >> uclib-menuconfig.  However; this has two issues with it:
 >> 
 >> 1) Most users wouldn't know that there is even a uClibc-menuconfig
 >> 2) Even if the user does select fts support in uClibc-menuconfig, the
 >> packages that would now compile and work would still not be selectable
 >> because they explicitly require BR2_TOOLCHAIN_USES_GLIBC.
 >> 
 >> Enabling fts support increases the size of uclibc by 75~kb according to
 >> the menuconfig option.  This is a acceptable size increase to fix the
 >> few packages that require fts.h support.
 >> 
 >> Signed-off-by: Adam Duskett <aduskett@gmail.com>

 > Peter, what is your thought on enabling FTS by default in our uClibc-ng
 > configuration ?

 > Note that contrary to what Adam commit log says, the size increase is
 > 7.5 KB.

Hmm, 7.5KB isn't much - But fts isn't enabled by default in uClibc-nc,
it is a legacy BSD feature and it also isn't supported by musl.

It is easy to enable uClibc options, but difficult to disable them again
later (as users of the affected packages get caught).

Looking around, it seems we are only talking about 3 packages (if the
annotations are correct):

git grep -l 'fts.h' **/Config.in
package/libcgroup/Config.in
package/libselinux/Config.in
package/libsemanage/Config.in

Do we care enough for selinux users on uClibc (libcgroup seems to only
be an optional dependency for gst1-rtsp-server) to let all other
uClibc-ng users pay?

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2017-07-15 15:15 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-13 14:25 [Buildroot] [PATCH 1/2] uclibc-ng: enable fts in default config file Adam Duskett
2017-07-13 14:25 ` [Buildroot] [PATCH 2/2] selinux packages: change glibc check to musl check Adam Duskett
2017-07-13 17:32 ` [Buildroot] [PATCH 1/2] uclibc-ng: enable fts in default config file Thomas Petazzoni
2017-07-13 17:41   ` Adam Duskett
2017-07-15  9:44 ` Thomas Petazzoni
2017-07-15 15:15   ` Peter Korsgaard [this message]
2017-07-15 17:16     ` Adam Duskett
2017-07-15 19:48     ` Thomas Petazzoni
2017-07-15 20:09       ` Adam Duskett
2017-07-16 15:53       ` Peter Korsgaard
2017-07-16 16:43         ` Waldemar Brodkorb
2017-07-16 17:40           ` Adam Duskett
2017-07-16 18:46             ` Yann E. MORIN
2017-07-18 19:24           ` Arnout Vandecappelle
2017-07-18 21:06             ` Thomas Petazzoni
2017-07-18 21:07               ` Waldemar Brodkorb
2017-10-12  1:06                 ` Alexey Brodkin
2017-10-12  7:52                   ` Thomas Petazzoni
2017-10-12 18:08                     ` Waldemar Brodkorb
2017-10-12 18:56                       ` ratbert90
2017-10-13 16:59                       ` Alexey Brodkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d191afyw.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox