From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] docs/manual: PEP8 coding style for Python scripts
Date: Thu, 27 Apr 2017 21:39:20 +0200 [thread overview]
Message-ID: <87d1bxk5cn.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20170424013356.2228-1-ricardo.martincoski@gmail.com> (Ricardo Martincoski's message of "Sun, 23 Apr 2017 22:33:56 -0300")
>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:
> The advantages of using a pre-existing coding style instead of creating
> our own are:
> - documenting on the manual takes a single sentence;
> - there are automatic tools to help during development/review.
> So document that PEP8 recommendation should be followed.
Seems sensible to me. Committed, thanks.
> Cc: Arnout Vandecappelle <arnout@mind.be>
> Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> Cc: Samuel Martin <s.martin49@gmail.com>
> Cc: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> ---
> Here is the sentence I didn't add:
> The use of https://pypi.python.org/pypi/pycodestyle[Python style guide checker]
> is recommended before submitting new scripts.
> I mentioned in a thread the tool pep8/pycodestyle
> From https://pypi.python.org/pypi/pycodestyle :
> "This package used to be called pep8 but was renamed to pycodestyle to
> reduce confusion"
> Old url: https://pypi.python.org/pypi/pep8
> Also Thomas DS mentioned the tool flake8 that seems to me to group:
> pycodestyle + pyflakes + mccabe
> http://flake8.pycqa.org/en/latest/
Ok. We don't get new python scripts that often, so it probably isn't a
huge deal.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2017-04-27 19:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 1:33 [Buildroot] [PATCH] docs/manual: PEP8 coding style for Python scripts Ricardo Martincoski
2017-04-27 19:39 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1bxk5cn.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox