Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] package/skeleton: ensure custom skeleton uses merged /usr if needed
Date: Wed, 11 Nov 2015 00:22:08 +0100	[thread overview]
Message-ID: <87d1vhphi7.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <d667c39209bc260f60546ee0b9e7f5a661c4b761.1447190450.git.yann.morin.1998@free.fr> (Yann E. MORIN's message of "Tue, 10 Nov 2015 22:36:30 +0100")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > When using systemd, the poolicy in Buildroot is to use a merged /usr
 > (see c5bd8af6, "system: add options for /bin /sbin and /lib to be
 > symlinks into /usr" for more info). So, we apply a few tricks in some
 > packages to account for the merged /usr case.

 > However, when using a custom skeleton, we have no say in how that
 > skeleton is organised, so it may well have a split /usr. In that case,
 > our little tricks might not work as expected.

 > So, when the user uses a custom skeleton and wants systemd as an init
 > system, we must check that the custom skeleton is setup with a merged
 > /usr.

 > We do that by checking that each pair of {/lib,/usr/lib} {/bin,/usr/bin}
 > and {/sbin,/usr/sbin} have the same inode numbers, i.e. /lib must have
 > the same inode number as /usr/lib (and so on...). When a pair does not
 > share the same inode number, this is not a merged /usr and we abort.

 > We implement that check with make constructs, so it is done very early
 > in the build process, and we can abort early if need be.

Nice. It doesn't handle cases where absolute symlinks are used
(E.G. /bin -> /usr/bin), but I don't see how we can fix that.

Committed series, thanks.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2015-11-10 23:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-10 21:36 [Buildroot] [pull request] skeleton: fix custom skeleton for use with systemd Yann E. MORIN
2015-11-10 21:36 ` [Buildroot] [PATCH 1/3] package/skeleton: qstrip path before using it Yann E. MORIN
2015-11-10 21:36 ` [Buildroot] [PATCH 2/3] package/skeleton: don't handle merged /usr for custom skeleton Yann E. MORIN
2015-11-10 21:36 ` [Buildroot] [PATCH 3/3] package/skeleton: ensure custom skeleton uses merged /usr if needed Yann E. MORIN
2015-11-10 23:22   ` Peter Korsgaard [this message]
2015-11-11 12:52     ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d1vhphi7.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox