From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libmemcached: don't use -fPIE and -pie with FLAT binaries
Date: Tue, 12 May 2015 00:19:14 +0200 [thread overview]
Message-ID: <87d226iwpp.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1431377736-2574-1-git-send-email-thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Mon, 11 May 2015 22:55:36 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> FLAT binaries cannot use -fPIE and -pie code, so let's teach
> libmemcached to not use such flags when BR2_BINFMT_FLAT=y.
> Fixes:
> http://autobuild.buildroot.org/results/8cb/8cbf57f9136cb42be31c88e0f1f32d3d2353e5ff/
> and many previous similar build failures
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> +# Help libmemcached to understand that -fPIE and -pie should not be
> +# used when FLAT binaries are used (shared libraries are not
> +# supported).
> +ifeq ($(BR2_BINFMT_FLAT),y)
> +LIBMEMCACHED_CONF_ENV += \
> + ax_cv_check_cflags__Werror__fPIE=no \
> + ax_cv_check_cflags__Werror__pie=no \
> + ax_cv_check_cxxflags__Werror__fPIE=no \
> + ax_cv_check_cxxflags__Werror__pie=no
> +endif
BINFMT_FLAT implies BR2_STATIC_LIBS and (elf) static libraries should
also not be built with -fPIE / -pie, right?
Is there any specific reason to only do this workaround for BINFMT_FLAT?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2015-05-11 22:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 20:55 [Buildroot] [PATCH] libmemcached: don't use -fPIE and -pie with FLAT binaries Thomas Petazzoni
2015-05-11 22:17 ` Romain Naour
2015-05-11 22:19 ` Peter Korsgaard [this message]
2015-05-12 11:26 ` Thomas Petazzoni
2015-05-12 12:20 ` Peter Korsgaard
2015-05-12 12:22 ` Thomas Petazzoni
2015-05-12 13:02 ` Peter Korsgaard
2015-05-12 14:17 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d226iwpp.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox