Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] libgtk2: skip tutorial and faq build
Date: Thu, 26 Feb 2015 22:58:12 +0100	[thread overview]
Message-ID: <87d24w5o97.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20150226173525.GA3914@free.fr> (Yann E. MORIN's message of "Thu,  26 Feb 2015 18:35:25 +0100")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

Hi,

 >> > + AC_CHECK_PROG(DB2HTML, db2html, true, false)
 >> > +-AM_CONDITIONAL(HAVE_DOCBOOK, $DB2HTML)
 >> > ++AM_CONDITIONAL([HAVE_DOCBOOK], [test ! "$DB2HTML" = "no"])
 >> 
 >> Why not just pass DB2HTML=false in LIBGTK2_CONF_ENV?

 > Weird, I was under the impression I did try that and that it did not
 > work... But Justin is reporting that it does work, so my memory are
 > obviously flawed...

Yes, as far as I can see AC_CHECK_PROG directly uses the shell variable
if defined:

https://www.gnu.org/software/autoconf/manual/autoconf-2.68/html_node/Generic-Programs.html

$DB2HTML directly expands to false, so AM_CONDITIONAL isn't true:

https://www.gnu.org/software/automake/manual/html_node/Usage-of-Conditionals.html

 >> What does that buy us? gtk-doc is disabled unless --enable-gtk-doc
 >> is passed (which we don't), so these shouldn't change anything.

 > Fact is, documentation is still generated even with
 > --disable-gtk-doc.

Really? That's not what I saw during my tests.

-- 
Venlig hilsen,
Peter Korsgaard 

      reply	other threads:[~2015-02-26 21:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24 23:50 [Buildroot] [PATCH v2] libgtk2: skip tutorial and faq build justin.swartz at nym.hush.com
2015-02-25 17:21 ` Yann E. MORIN
2015-02-25 23:17 ` Peter Korsgaard
2015-02-26 16:34   ` justin.swartz at nym.hush.com
2015-02-26 21:16     ` Peter Korsgaard
2015-02-26 21:50       ` Yann E. MORIN
2015-02-26 22:10         ` Peter Korsgaard
2015-02-26 16:55   ` [Buildroot] [PATCH v3] " justin.swartz at nym.hush.com
2015-02-26 20:04     ` Yann E. MORIN
2015-02-26 22:00     ` Peter Korsgaard
2015-02-26 17:35   ` [Buildroot] [PATCH v2] " Yann E. MORIN
2015-02-26 21:58     ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d24w5o97.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox