Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] triggerhappy: new package
Date: Fri, 12 Dec 2014 08:40:16 +0100	[thread overview]
Message-ID: <87d27ps4db.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20141212000823.72d27f28@free-electrons.com> (Thomas Petazzoni's message of "Fri, 12 Dec 2014 00:08:23 +0100")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > Dear Peter Korsgaard,
 > On Mon,  8 Dec 2014 23:55:28 +0100, Peter Korsgaard wrote:
 >> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
 >> ---
 >> package/Config.in                    |  1 +
 >> package/triggerhappy/Config.in       | 10 +++++++++
 >> package/triggerhappy/S10triggerhappy | 40 ++++++++++++++++++++++++++++++++++++
 >> package/triggerhappy/triggerhappy.mk | 37 +++++++++++++++++++++++++++++++++
 >> 4 files changed, 88 insertions(+)
 >> create mode 100644 package/triggerhappy/Config.in
 >> create mode 100755 package/triggerhappy/S10triggerhappy
 >> create mode 100644 package/triggerhappy/triggerhappy.mk

 > Thanks, applied, with two small changes:

 >     [Thomas:
 >       - add BR2_USE_MMU dependency, since fork() is used

Ahh yes, true.

>       - rename do_start() and do_stop() to just start() and stop(), as we
 >         do in most init scripts in Buildroot.]

I believe I just copied the init script from the upmpdcli package, so we
do have a few init scripts using do_start/do_stop:

git grep -l do_s package/**/S*
package/rpi-userland/S94vcfiled
package/transmission/S92transmission
package/upmpdcli/S99upmpdcli

So I'll fix those up for consistency. Thanks!

-- 
Venlig hilsen,
Peter Korsgaard 

  reply	other threads:[~2014-12-12  7:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-08 22:55 [Buildroot] [PATCH] triggerhappy: new package Peter Korsgaard
2014-12-11 23:08 ` Thomas Petazzoni
2014-12-12  7:40   ` Peter Korsgaard [this message]
2014-12-12  7:54     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d27ps4db.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox