From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2 v2] package/util-linux: libuuid needs -lintl
Date: Mon, 01 Dec 2014 00:19:30 +0100 [thread overview]
Message-ID: <87d284i8e5.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <cb66bb193b20ce08d5184a4eae854e9a0fa384f6.1417386541.git.yann.morin.1998@free.fr> (Yann E. MORIN's message of "Sun, 30 Nov 2014 23:31:36 +0100")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> When gettext is needed (with locales), libuuid needs to be linked
> against -lintl.
> In dynamic link, this is solved via the DT_NEEDED ELF tag, but for
> static links, it does not get pulled in automatically.
> Fix that by adding a Libs.private section to uuid.pc, but only if
> it needed.
> First part at fixing:
> http://autobuild.buildroot.net/results/c46/c467aeec258909bb82eda77123803944f97d8df8/
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Baruch Siach <baruch@tkos.co.il>
> ---
> Changes v1 -> v2:
> - typo (Baruch)
> ---
> package/util-linux/util-linux.mk | 8 ++++++++
> 1 file changed, 8 insertions(+)
> diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk
> index 6ecd16d..dc10193 100644
> --- a/package/util-linux/util-linux.mk
> +++ b/package/util-linux/util-linux.mk
> @@ -128,6 +128,14 @@ endif
> UTIL_LINUX_POST_INSTALL_TARGET_HOOKS += UTIL_LINUX_GETTY_SYMLINK
> +ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE)$(BR2_PACKAGE_UTIL_LINUX_LIBUUID),yy)
> +define UTIL_LINUX_TWEAK_UUID_PC
> + $(SED) '/Libs\.private: .*/d' $(STAGING_DIR)/usr/lib/pkgconfig/uuid.pc
> + printf "Libs.private: -lintl\n" >>$(STAGING_DIR)/usr/lib/pkgconfig/uuid.pc
> +endef
As discussed on IRC, I don't think the SED line is needed - But lets
leave it here to be on the safe side.
Committed, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2014-11-30 23:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-30 22:31 [Buildroot] [PATCH 0/2 v2] parted: fix static link (branch yem/for-release) Yann E. MORIN
2014-11-30 22:31 ` [Buildroot] [PATCH 1/2 v2] package/util-linux: libuuid needs -lintl Yann E. MORIN
2014-11-30 23:19 ` Peter Korsgaard [this message]
2014-11-30 22:31 ` [Buildroot] [PATCH 2/2 v2] package/parted: fix static link Yann E. MORIN
2014-11-30 23:20 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d284i8e5.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox