From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] hdparm: prevent package makefile from stripping the hdparm binary
Date: Mon, 16 Jun 2014 09:24:22 +0200 [thread overview]
Message-ID: <87d2e9co61.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <539E822C.5040708@mind.be> (Arnout Vandecappelle's message of "Mon, 16 Jun 2014 07:35:40 +0200")
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
> On 06/11/14 23:03, Peter Korsgaard wrote:
>> +++ b/package/hdparm/hdparm.mk
>> @@ -12,7 +12,8 @@ HDPARM_LICENSE_FILES = LICENSE.TXT
>> define HDPARM_BUILD_CMDS
>> $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) \
>> CFLAGS="$(TARGET_CFLAGS)" \
>> - LDFLAGS="$(TARGET_LDFLAGS)"
>> + LDFLAGS="$(TARGET_LDFLAGS)" \
>> + STRIP=/bin/true
> Perhaps for consistency we should rename $(TARGET_CROSS)strip to
> $(TARGET_CROSS)real-strip and symlink $(TARGET_CROSS)strip to /bin/true?
Most of these packages presumably default to 'strip' and not
'$(TARGET_CROSS)strip', so it won't help much.
> While looking at this, I also notice that in some cases we _do_ pass the real
> strip, e.g. in fltk, qt (but not qt5). I guess that's historical accident?
I would think so. For fltk atleast it dates back from 2008. I'll take a
look at fixing it up, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2014-06-16 7:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 21:03 [Buildroot] [git commit] hdparm: prevent package makefile from stripping the hdparm binary Peter Korsgaard
2014-06-16 5:35 ` Arnout Vandecappelle
2014-06-16 7:24 ` Peter Korsgaard [this message]
2014-06-16 7:34 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2e9co61.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox