From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] scripts: xorg-release: handle case when version needs downgrade
Date: Tue, 04 Feb 2014 10:32:35 +0100 [thread overview]
Message-ID: <87d2j3i5os.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1391505976-13477-1-git-send-email-thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Tue, 4 Feb 2014 10:26:16 +0100")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> From: Nicolas Dechesne <ndec13@gmail.com>
> the initial implementation assumes that when a version found in
> buildroot is different from the one in the X11 release, it
> requires an upgrade. even though this is most likely the case, it
> could be a downgrade too, and it's probably worth highlighting
> such cases when it (rarely) happens.
> LooseVersion from distutils is doing the low level job of sorting
> version numbers represented in strings...
> [Thomas & Thomas:
> - do not count packages more recent in Buildroot than in the latest
> X.org release as to be downgraded. If we have more recent version,
> it's generally for a good reason, so we want to keep them as
> is. Such packages are counted as "nothing to do", but for
> information, we indicate that there are "More recent"
> - also remove the "nothing to do" action indicator. It used to be a
> simple dash, which was not really useful.
> ]
> Signed-off-by: Nicolas Dechesne <ndec13@gmail.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Committed, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2014-02-04 9:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 9:26 [Buildroot] [PATCH] scripts: xorg-release: handle case when version needs downgrade Thomas Petazzoni
2014-02-04 9:32 ` Peter Korsgaard [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-02-04 22:47 Nicolas Dechesne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2j3i5os.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox