From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] pkg-stats: fix proper identification of package infrastructure
Date: Wed, 11 Sep 2013 13:06:07 +0200 [thread overview]
Message-ID: <87d2ofsjmo.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <CAAXf6LXW33j4R5+r1mmJ8-MF-wAvWr54_dk+8z88O-GruEhmNw@mail.gmail.com> (Thomas De Schampheleire's message of "Wed, 11 Sep 2013 11:53:30 +0200")
>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:
Thomas> Hi,
Thomas> On Wed, Sep 11, 2013 at 11:12 AM, Jerzy Grzegorek
Thomas> <jerzy.grzegorek@trzebnica.net> wrote:
>> Typically each package invokes the macro which generates the Makefile code, in the way
>> like this: e.g. $(eval $(generic-package)) or $(eval $(autotools-package)) ,
>> but a few packages have to invoke this macro in other way:
>> $(eval $(call generic-package)) e.g. dhcpcd.mk
>> $(eval $(call autotools-package)) e.g. wireshark.mk .
Thomas> I rather think that the 'call' is an accident. Arnout removed the need
Thomas> for the extra $(call) in July 2012, with commit
Thomas> e1502ebc0c92763896c53d405ee9c7c7a1a33e24, and both dhcpcd and
Thomas> wireshark were added after that time. So I think this has been missed
Thomas> during code review.
Thomas> A quick search shows only three packages with a remaining $(eval
Thomas> $(call)) construct: dhcpcd, wireshark, jquery-keyboard.
Thomas> So I'd rather fix those packages...
Agreed, I've fixed those in git now.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2013-09-11 11:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 9:12 [Buildroot] [PATCH 1/2] pkg-stats: update set of files to skip Jerzy Grzegorek
2013-09-11 9:12 ` [Buildroot] [PATCH 2/2] pkg-stats: fix proper identification of package infrastructure Jerzy Grzegorek
2013-09-11 9:53 ` Thomas De Schampheleire
2013-09-11 11:06 ` Peter Korsgaard [this message]
2013-09-11 11:24 ` Jerzy Grzegorek
2013-09-11 11:02 ` [Buildroot] [PATCH 1/2] pkg-stats: update set of files to skip Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2ofsjmo.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox