Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] Makefile: export BR2_CONFIG_FILE, pointing to our .config
Date: Sun, 13 Jan 2013 21:45:42 +0100	[thread overview]
Message-ID: <87d2x8x155.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <50EC2CE0.2050106@mind.be> (Arnout Vandecappelle's message of "Tue, 08 Jan 2013 15:27:44 +0100")

>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

Hi,

 >> I was not referring to our .mk files, but rather to the packages themselves.
 >> I did a quick survey in 110+ packages, and:
 >> - kconfig-based packages are not affected: kernel, uClibc, busybox, ct-ng
 >> - packages using CONFIG_FILE:
 >> - gdb:     gdb/sim/ppc/Makefile.in:CONFIG_FILE = @sim_config@
 >> - xbmc:    xbmc/lib/freetype/builds/detect.mk:ifndef CONFIG_FILE
 >> - no package uses DOT_CONFIG
 >> - openbricks is using DOT_CONFIG, too

 Arnout>  But if you anyway change the name, BUILDROOT_CONFIG is better than
 Arnout> the non-specific DOT_CONFIG.

 Arnout>  How long can we discuss about a name? :-)

Long ;)

I like BUILDROOT_CONFIG. It's unique and it's meaning is very
obvious. Yann, care to rework the series to use BUILDROOT_CONFIG
instead?

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2013-01-13 20:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-07 21:52 [Buildroot] [pull request] Pull request for branch yem-misc-fixes Yann E. MORIN
2013-01-07 21:52 ` [Buildroot] [PATCH 1/3] Makefile: export BR2_CONFIG_FILE, pointing to our .config Yann E. MORIN
2013-01-07 22:10   ` Yann E. MORIN
2013-01-08  6:50   ` Arnout Vandecappelle
2013-01-08 12:51     ` Yann E. MORIN
2013-01-08 13:07       ` Arnout Vandecappelle
2013-01-08 13:46         ` Yann E. MORIN
2013-01-08 14:27           ` Arnout Vandecappelle
2013-01-13 20:45             ` Peter Korsgaard [this message]
2013-01-13 21:34               ` Yann E. MORIN
2013-01-07 21:52 ` [Buildroot] [PATCH 2/3] support/dependencies: use globally-exported BR2_CONFIG_FILE Yann E. MORIN
2013-01-07 21:52 ` [Buildroot] [PATCH 3/3] toolchain/crostool-ng: use globally-exported CONFIG_FILE Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d2x8x155.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox