From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] linux: fix linux-% shortcut targets
Date: Sun, 19 Dec 2010 21:15:40 +0100 [thread overview]
Message-ID: <87d3ox1pub.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1292783849-8766-2-git-send-email-bjorn.forsman@gmail.com> ("Bjørn Forsman"'s message of "Sun, 19 Dec 2010 19:37:29 +0100")
>>>>> "Bj?rn" == Bj?rn Forsman <bjorn.forsman@gmail.com> writes:
Hi,
Bj?rn> linux-% shortcut targets (short for linux26-%) ignores the ouput
Bj?rn> dir $(O) so that 'make O=output.arm linux-menuconfig' is
Bj?rn> actually run in the default $(O) directory output/ and not in
Bj?rn> output.arm/. Fix by passing on $(O).
This is still not correct. You should only pass O= if it was given on
the command line, otherwise BR will look in output/.config for the
configuration for non-out-of-tree-builds. I've added EXTRAMAKEARGS in
the toplevel makefile a while ago to handle it.
Committed with that change.
Bj?rn> Signed-off-by: Bj?rn Forsman <bjorn.forsman@gmail.com>
Bj?rn> ---
Bj?rn> linux/linux.mk | 2 +-
Bj?rn> 1 files changed, 1 insertions(+), 1 deletions(-)
Bj?rn> diff --git a/linux/linux.mk b/linux/linux.mk
Bj?rn> index 6636a35..68d2d6d 100644
Bj?rn> --- a/linux/linux.mk
Bj?rn> +++ b/linux/linux.mk
Bj?rn> @@ -200,4 +200,4 @@ endif
Bj?rn> endif
Bj?rn> linux-%:
Bj?rn> - $(MAKE) $(subst linux-,linux26-,$@)
Bj?rn> + $(MAKE) O=$(O) $(subst linux-,linux26-,$@)
Bj?rn> --
Bj?rn> 1.7.1
Bj?rn> _______________________________________________
Bj?rn> buildroot mailing list
Bj?rn> buildroot at busybox.net
Bj?rn> http://lists.busybox.net/mailman/listinfo/buildroot
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2010-12-19 20:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-19 18:37 [Buildroot] [PATCH 1/2] linux: support 'make linux26-nconfig' Bjørn Forsman
2010-12-19 18:37 ` [Buildroot] [PATCH 2/2] linux: fix linux-% shortcut targets Bjørn Forsman
2010-12-19 20:15 ` Peter Korsgaard [this message]
2010-12-19 20:39 ` Bjørn Forsman
2010-12-19 20:17 ` [Buildroot] [PATCH 1/2] linux: support 'make linux26-nconfig' Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d3ox1pub.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox