Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] linux: support 'make linux26-nconfig'
@ 2010-12-19 18:37 Bjørn Forsman
  2010-12-19 18:37 ` [Buildroot] [PATCH 2/2] linux: fix linux-% shortcut targets Bjørn Forsman
  2010-12-19 20:17 ` [Buildroot] [PATCH 1/2] linux: support 'make linux26-nconfig' Peter Korsgaard
  0 siblings, 2 replies; 5+ messages in thread
From: Bjørn Forsman @ 2010-12-19 18:37 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Bj?rn Forsman <bjorn.forsman@gmail.com>
---
 linux/linux.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/linux/linux.mk b/linux/linux.mk
index 23b89cf..6636a35 100644
--- a/linux/linux.mk
+++ b/linux/linux.mk
@@ -159,7 +159,7 @@ $(LINUX26_DIR)/.stamp_installed: $(LINUX26_DIR)/.stamp_compiled
 
 linux26: host-module-init-tools $(LINUX26_DEPENDENCIES) $(LINUX26_DIR)/.stamp_installed
 
-linux26-menuconfig linux26-xconfig linux26-gconfig: dirs $(LINUX26_DIR)/.stamp_configured
+linux26-menuconfig linux26-xconfig linux26-gconfig linux26-nconfig: dirs $(LINUX26_DIR)/.stamp_configured
 	$(MAKE) $(LINUX26_MAKE_FLAGS) -C $(LINUX26_DIR) $(subst linux26-,,$@)
 
 # Support for rebuilding the kernel after the initramfs file list has
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 2/2] linux: fix linux-% shortcut targets
  2010-12-19 18:37 [Buildroot] [PATCH 1/2] linux: support 'make linux26-nconfig' Bjørn Forsman
@ 2010-12-19 18:37 ` Bjørn Forsman
  2010-12-19 20:15   ` Peter Korsgaard
  2010-12-19 20:17 ` [Buildroot] [PATCH 1/2] linux: support 'make linux26-nconfig' Peter Korsgaard
  1 sibling, 1 reply; 5+ messages in thread
From: Bjørn Forsman @ 2010-12-19 18:37 UTC (permalink / raw)
  To: buildroot

linux-% shortcut targets (short for linux26-%) ignores the ouput dir
$(O) so that 'make O=output.arm linux-menuconfig' is actually run in the
default $(O) directory output/ and not in output.arm/. Fix by passing on
$(O).

Signed-off-by: Bj?rn Forsman <bjorn.forsman@gmail.com>
---
 linux/linux.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/linux/linux.mk b/linux/linux.mk
index 6636a35..68d2d6d 100644
--- a/linux/linux.mk
+++ b/linux/linux.mk
@@ -200,4 +200,4 @@ endif
 endif
 
 linux-%:
-	$(MAKE) $(subst linux-,linux26-,$@)
+	$(MAKE) O=$(O) $(subst linux-,linux26-,$@)
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 2/2] linux: fix linux-% shortcut targets
  2010-12-19 18:37 ` [Buildroot] [PATCH 2/2] linux: fix linux-% shortcut targets Bjørn Forsman
@ 2010-12-19 20:15   ` Peter Korsgaard
  2010-12-19 20:39     ` Bjørn Forsman
  0 siblings, 1 reply; 5+ messages in thread
From: Peter Korsgaard @ 2010-12-19 20:15 UTC (permalink / raw)
  To: buildroot

>>>>> "Bj?rn" == Bj?rn Forsman <bjorn.forsman@gmail.com> writes:

Hi,

 Bj?rn> linux-% shortcut targets (short for linux26-%) ignores the ouput
 Bj?rn> dir $(O) so that 'make O=output.arm linux-menuconfig' is
 Bj?rn> actually run in the default $(O) directory output/ and not in
 Bj?rn> output.arm/. Fix by passing on $(O).

This is still not correct. You should only pass O= if it was given on
the command line, otherwise BR will look in output/.config for the
configuration for non-out-of-tree-builds. I've added EXTRAMAKEARGS in
the toplevel makefile a while ago to handle it.

Committed with that change.

 Bj?rn> Signed-off-by: Bj?rn Forsman <bjorn.forsman@gmail.com>
 Bj?rn> ---
 Bj?rn>  linux/linux.mk |    2 +-
 Bj?rn>  1 files changed, 1 insertions(+), 1 deletions(-)

 Bj?rn> diff --git a/linux/linux.mk b/linux/linux.mk
 Bj?rn> index 6636a35..68d2d6d 100644
 Bj?rn> --- a/linux/linux.mk
 Bj?rn> +++ b/linux/linux.mk
 Bj?rn> @@ -200,4 +200,4 @@ endif
 Bj?rn>  endif
 
 Bj?rn>  linux-%:
 Bj?rn> -	$(MAKE) $(subst linux-,linux26-,$@)
 Bj?rn> +	$(MAKE) O=$(O) $(subst linux-,linux26-,$@)
 Bj?rn> -- 
 Bj?rn> 1.7.1

 Bj?rn> _______________________________________________
 Bj?rn> buildroot mailing list
 Bj?rn> buildroot at busybox.net
 Bj?rn> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/2] linux: support 'make linux26-nconfig'
  2010-12-19 18:37 [Buildroot] [PATCH 1/2] linux: support 'make linux26-nconfig' Bjørn Forsman
  2010-12-19 18:37 ` [Buildroot] [PATCH 2/2] linux: fix linux-% shortcut targets Bjørn Forsman
@ 2010-12-19 20:17 ` Peter Korsgaard
  1 sibling, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2010-12-19 20:17 UTC (permalink / raw)
  To: buildroot

>>>>> "Bj?rn" == Bj?rn Forsman <bjorn.forsman@gmail.com> writes:

 Bj?rn> Signed-off-by: Bj?rn Forsman <bjorn.forsman@gmail.com>
 Bj?rn> ---
 Bj?rn>  linux/linux.mk |    2 +-
 Bj?rn>  1 files changed, 1 insertions(+), 1 deletions(-)

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 2/2] linux: fix linux-% shortcut targets
  2010-12-19 20:15   ` Peter Korsgaard
@ 2010-12-19 20:39     ` Bjørn Forsman
  0 siblings, 0 replies; 5+ messages in thread
From: Bjørn Forsman @ 2010-12-19 20:39 UTC (permalink / raw)
  To: buildroot

Hi,

2010/12/19 Peter Korsgaard <jacmet@uclibc.org>:
>>>>>> "Bj?rn" == Bj?rn Forsman <bjorn.forsman@gmail.com> writes:
>
> Hi,
>
> ?Bj?rn> linux-% shortcut targets (short for linux26-%) ignores the ouput
> ?Bj?rn> dir $(O) so that 'make O=output.arm linux-menuconfig' is
> ?Bj?rn> actually run in the default $(O) directory output/ and not in
> ?Bj?rn> output.arm/. Fix by passing on $(O).
>
> This is still not correct. You should only pass O= if it was given on
> the command line, otherwise BR will look in output/.config for the
> configuration for non-out-of-tree-builds. I've added EXTRAMAKEARGS in
> the toplevel makefile a while ago to handle it.
>
> Committed with that change.

Thanks for fixing and committing!

Best regards,
Bj?rn Forsman

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2010-12-19 20:39 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-19 18:37 [Buildroot] [PATCH 1/2] linux: support 'make linux26-nconfig' Bjørn Forsman
2010-12-19 18:37 ` [Buildroot] [PATCH 2/2] linux: fix linux-% shortcut targets Bjørn Forsman
2010-12-19 20:15   ` Peter Korsgaard
2010-12-19 20:39     ` Bjørn Forsman
2010-12-19 20:17 ` [Buildroot] [PATCH 1/2] linux: support 'make linux26-nconfig' Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox