From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 03/21] udpcast: convert to the autotools infrastructure
Date: Mon, 12 Apr 2010 19:48:49 +0200 [thread overview]
Message-ID: <87d3y4k1dq.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <b7fe41a1f4c9fc78ea89fe332a7d98d2922ed83f.1271077873.git.thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Mon, 12 Apr 2010 15:11:15 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Thomas> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thomas> ---
Thomas> package/udpcast/udpcast.mk | 93 +++++++-------------------------------------
Thomas> -UDPCAST_CAT:=$(ZCAT)
Thomas> -UDPCAST_DIR:=$(BUILD_DIR)/udpcast-$(UDPCAST_VERSION)
Thomas> +UDPCAST_INSTALL_TARGET_OPT=DESTDIR=$(TARGET_DIR) install
Thomas> +UDPCAST_CONF_ENV = ac_cv_type_stat64=yes
Thomas> - $(if $(BR_LARGEFILE),ac_cv_type_stat64=yes,ac_cv_type_stat64=no) \
Why are you now forcing 64bit here?
Thomas> +
Thomas> +$(eval $(call AUTOTARGETS,package,udpcast))
Thomas> \ No newline at end of file
Not a big deal, but you seem to forgot the final newline in several
files - Is there any reason why?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2010-04-12 17:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-12 13:11 [Buildroot] [pull request] Pull request for branch autotools-conversion Thomas Petazzoni
2010-04-12 13:11 ` [Buildroot] [PATCH 01/21] vtun: convert to the autotools infrastructure Thomas Petazzoni
2010-04-12 13:11 ` [Buildroot] [PATCH 02/21] x11vnc: cleanup useless config options Thomas Petazzoni
2010-04-12 13:11 ` [Buildroot] [PATCH 03/21] udpcast: convert to the autotools infrastructure Thomas Petazzoni
2010-04-12 17:48 ` Peter Korsgaard [this message]
2010-04-13 14:59 ` Thomas Petazzoni
2010-04-13 19:51 ` Peter Korsgaard
2010-04-12 13:11 ` [Buildroot] [PATCH 04/21] setserial: " Thomas Petazzoni
2010-04-12 13:11 ` [Buildroot] [PATCH 05/21] smartmontools: " Thomas Petazzoni
2010-04-12 13:11 ` [Buildroot] [PATCH 06/21] patch: convert to the autotools infrastructure and bump version Thomas Petazzoni
2010-04-12 13:11 ` [Buildroot] [PATCH 07/21] libosip2: convert to the autotools infrastructure Thomas Petazzoni
2010-04-12 13:11 ` [Buildroot] [PATCH 08/21] libcgicc: " Thomas Petazzoni
2010-04-12 13:11 ` [Buildroot] [PATCH 09/21] libraw1394: " Thomas Petazzoni
2010-04-12 13:11 ` [Buildroot] [PATCH 10/21] libsysfs: " Thomas Petazzoni
2010-04-12 13:11 ` [Buildroot] [PATCH 11/21] libcgi: " Thomas Petazzoni
2010-04-12 13:11 ` [Buildroot] [PATCH 12/21] Remove incorrect 'dummy' example Thomas Petazzoni
2010-04-12 13:11 ` [Buildroot] [PATCH 13/21] bison: convert to the autotools infrastructure Thomas Petazzoni
2010-04-12 13:11 ` [Buildroot] [PATCH 14/21] tar: " Thomas Petazzoni
2010-04-12 13:11 ` [Buildroot] [PATCH 15/21] argus: " Thomas Petazzoni
2010-04-12 13:11 ` [Buildroot] [PATCH 16/21] ipkg: remove useless configure options Thomas Petazzoni
2010-04-12 13:11 ` [Buildroot] [PATCH 17/21] findutils: convert to the autotools infrastructure Thomas Petazzoni
2010-04-12 13:11 ` [Buildroot] [PATCH 18/21] madplay: " Thomas Petazzoni
2010-04-12 13:11 ` [Buildroot] [PATCH 19/21] aumix: " Thomas Petazzoni
2010-04-12 13:11 ` [Buildroot] [PATCH 20/21] libmad: " Thomas Petazzoni
2010-04-12 13:11 ` [Buildroot] [PATCH 21/21] libid3tag: " Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d3y4k1dq.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox