Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: Maxim Kochetkov via buildroot <buildroot@buildroot.org>
Cc: Maxim Kochetkov <fido_max@inbox.ru>,  Bernd Kuhls <bernd@kuhls.net>
Subject: Re: [Buildroot] [PATCH 1/1] package/alsa-lib: add BR2_USE_MMU dependency
Date: Fri, 29 Nov 2024 14:39:41 +0200	[thread overview]
Message-ID: <87ed2u6woi.fsf@tarshish> (raw)
In-Reply-To: <20241129111156.629528-1-fido_max@inbox.ru> (Maxim Kochetkov via buildroot's message of "Fri, 29 Nov 2024 14:11:56 +0300")

Hi Maxim,

On Fri, Nov 29 2024, Maxim Kochetkov via buildroot wrote:
> Build fails with:
> ucm_exec.c: In function 'uc_mgr_exec':
> ucm_exec.c:229:13: error: implicit declaration of function 'fork' [-Wimplicit-function-declaration]
>   229 |         p = fork();
>       |             ^~~~
>
> ucm uses fork() so add BR2_USE_MMU dependency for it.
>
> Fixes: https://autobuild.buildroot.org/results/a287d3eef7ea5ea9a85b5b35d14e3698df4ecd01/build-end.log
> Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
> ---
>  package/alsa-lib/Config.in | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/package/alsa-lib/Config.in b/package/alsa-lib/Config.in
> index 447916a29f..98b61896d4 100644
> --- a/package/alsa-lib/Config.in
> +++ b/package/alsa-lib/Config.in
> @@ -69,8 +69,12 @@ config BR2_PACKAGE_ALSA_LIB_SEQ
>  config BR2_PACKAGE_ALSA_LIB_UCM
>  	bool "ucm"
>  	default y
> +	depends on BR2_USE_MMU # fork()
>  	select BR2_PACKAGE_ALSA_LIB_MIXER
>  
> +comment "ucm needs a toolchain w/ fork support"
> +	depends on !BR2_USE_MMU
> +

BR2_USE_MMU describes the target platform. This is not a toolchain
option user can change. For this reason we don't add comments for this
dependency.

See section 18.2.4 in the Buildroot manual:

  https://buildroot.org/downloads/manual/manual.html

baruch

>  config BR2_PACKAGE_ALSA_LIB_ALISP
>  	bool "alisp"
>  	default y

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2024-11-29 12:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-29 11:11 [Buildroot] [PATCH 1/1] package/alsa-lib: add BR2_USE_MMU dependency Maxim Kochetkov via buildroot
2024-11-29 12:39 ` Baruch Siach via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ed2u6woi.fsf@tarshish \
    --to=buildroot@buildroot.org \
    --cc=baruch@tkos.co.il \
    --cc=bernd@kuhls.net \
    --cc=fido_max@inbox.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox