From: Peter Korsgaard <peter@korsgaard.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/botan: fix build without NPTL
Date: Wed, 06 Mar 2024 15:18:20 +0100 [thread overview]
Message-ID: <87edcnxx3n.fsf@48ers.dk> (raw)
In-Reply-To: <20240305125256.480327-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Tue, 5 Mar 2024 13:52:56 +0100")
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> botan unconditionally uses pthread_setname_np since bump to version
> 3.2.0 in commit 2f8feb66204ff661e9fd5f508e2dfd1ebc0f2813 and
> https://github.com/randombit/botan/commit/313e439c786d68bcf374b2cb0edfe3ffd891db94
> resulting in the following build failure:
> src/lib/utils/os_utils.cpp:625:22: error: 'pthread_setname_np' was not declared in this scope
> 625 | static_cast<void>(pthread_setname_np(thread.native_handle(), name.c_str()));
> | ^~~~~~~~~~~~~~~~~~
> So only enable threads if NPTL is available
> Fixes: 2f8feb66204ff661e9fd5f508e2dfd1ebc0f2813
> - http://autobuild.buildroot.org/results/03677de6270ff5de61fff2a76e5cd723aa34e64e
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-03-06 14:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 12:52 [Buildroot] [PATCH 1/1] package/botan: fix build without NPTL Fabrice Fontaine
2024-03-06 14:18 ` Peter Korsgaard [this message]
2024-03-20 20:37 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edcnxx3n.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox