Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Uladzimir Bely <wiselord1983@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/python-mpd2: new package
Date: Fri, 07 Jan 2022 21:50:35 +0100	[thread overview]
Message-ID: <87ee5jl17o.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20220105231543.22467-1-wiselord1983@gmail.com> (Uladzimir Bely's message of "Thu, 6 Jan 2022 02:15:43 +0300")

>>>>> "Uladzimir" == Uladzimir Bely <wiselord1983@gmail.com> writes:

 > A client interface for the Music Player Daemon.
 > Signed-off-by: Uladzimir Bely <wiselord1983@gmail.com>
 > ---
 >  package/Config.in                    |  1 +
 >  package/python-mpd2/Config.in        |  8 ++++++++
 >  package/python-mpd2/python-mpd2.hash |  5 +++++
 >  package/python-mpd2/python-mpd2.mk   | 13 +++++++++++++
 >  4 files changed, 27 insertions(+)
 >  create mode 100644 package/python-mpd2/Config.in
 >  create mode 100644 package/python-mpd2/python-mpd2.hash
 >  create mode 100644 package/python-mpd2/python-mpd2.mk

 > diff --git a/package/Config.in b/package/Config.in
 > index 7148639735..b9dc9b49e7 100644
 > --- a/package/Config.in
 > +++ b/package/Config.in
 > @@ -1091,6 +1091,7 @@ menu "External python modules"
 >  	source "package/python-mistune/Config.in"
 >  	source "package/python-modbus-tk/Config.in"
 >  	source "package/python-more-itertools/Config.in"
 > +	source "package/python-mpd2/Config.in"
 >  	source "package/python-msgfy/Config.in"
 >  	source "package/python-msgpack/Config.in"
 >  	source "package/python-multidict/Config.in"
 > diff --git a/package/python-mpd2/Config.in b/package/python-mpd2/Config.in
 > new file mode 100644
 > index 0000000000..015ca47610
 > --- /dev/null
 > +++ b/package/python-mpd2/Config.in
 > @@ -0,0 +1,8 @@
 > +config BR2_PACKAGE_PYTHON_MPD2
 > +	bool "python-mpd2"
 > +	depends on BR2_PACKAGE_PYTHON3
 > +	select BR2_PACKAGE_MPD # runtime

This assumes that the MPD daemon must be running on the same machine as
the client, which is probably not always the case, so I have removed
this.

 > +++ b/package/python-mpd2/python-mpd2.mk
 > @@ -0,0 +1,13 @@
 > +################################################################################
 > +#
 > +# python-mpd2
 > +#
 > +################################################################################
 > +
 > +PYTHON_MPD2_VERSION = 3.0.4
 > +PYTHON_MPD2_SITE = https://files.pythonhosted.org/packages/ad/92/bec26455a3a6d6146bcf2a974f5c3509d451306413b386fc12b037d9e3b0
 > +PYTHON_MPD2_SETUP_TYPE = setuptools
 > +PYTHON_MPD2_LICENSE = GNU Library or Lesser General Public License (LGPL)

We can be more specific than that. The license is actually version 3 (or
later) of the LGPL, which is encoded as LGPL-3.0+

I also took the liberty to add an entry in DEVELOPERS for this
package. Committed with these minor fixes, thanks!

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2022-01-07 20:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-05 23:15 [Buildroot] [PATCH] package/python-mpd2: new package Uladzimir Bely
2022-01-07 20:50 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ee5jl17o.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@buildroot.org \
    --cc=wiselord1983@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox