From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] package/kf5-kcoreaddons: fix check-package warnings
Date: Mon, 23 Dec 2019 23:14:47 +0100 [thread overview]
Message-ID: <87eewuu1t4.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20191222094810.736238D4B7@busybox.osuosl.org> (Yann E. MORIN's message of "Sun, 22 Dec 2019 10:57:14 +0100")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> commit: https://git.buildroot.net/buildroot/commit/?id=f7e750e8f514f84bf2f4fc99976dd11f19c8ecbc
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> KF5_KCOREADDONS_CONF_OPTS is set both outside and inside the
> conditional block, so the value set outside would be lost if
> the condition were to be true.
> Use append-assignement in this case, as reported by check-package.
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Committed to 2019.02.x and 2019.11.x, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2019-12-23 22:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-22 9:57 [Buildroot] [git commit] package/kf5-kcoreaddons: fix check-package warnings Yann E. MORIN
2019-12-22 10:23 ` Giulio Benetti
2019-12-22 10:37 ` Yann E. MORIN
2019-12-22 11:58 ` Giulio Benetti
2019-12-23 22:14 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eewuu1t4.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox