From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] go: explicitly disable modules to avoid unintended network lookup
Date: Sun, 03 Mar 2019 22:17:39 +0100 [thread overview]
Message-ID: <87ef7nk68c.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <87lg1wg1wf.fsf@paral.in> (Christian Stewart's message of "Sat, 02 Mar 2019 17:52:32 -0800")
>>>>> "Christian" == Christian Stewart <christian@paral.in> writes:
> Hi All,
> Anisse Astier <anisse@astier.eu> writes:
>>> If you do this reproduction with ANY > go1.11 version of Buildroot
>>> today:
>>>
>>> export GO111MODULE=on
>>> make docker-engine
>>>
>>> Then Buildroot will leak the GO111MODULE variable into the build
>>> process, and Go will start downloading dependencies from the internet
>>> and ignore GOPATH.
>>>
>>> Here is a reproduction, where Go makes network calls:
>>>
>>> https://asciinema.org/a/pKktUhsN2NDoWkiCEgW9iUPbA
> This is still the case today. What are the statuses of these patches?
> - https://patchwork.ozlabs.org/patch/1031429/
I have just applied it now.
> - https://patchwork.ozlabs.org/patch/1048076/
This is for next / post 2019.02. I haven't looked closely at it yet, but
will do so soon.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2019-03-03 21:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-26 10:23 [Buildroot] [PATCH 1/1] go: explicitly disable modules to avoid unintended network lookup Christian Stewart
2019-01-28 12:59 ` Anisse Astier
2019-02-12 9:14 ` Christian Stewart
2019-02-12 16:57 ` Anisse Astier
2019-02-13 0:32 ` Christian Stewart
2019-02-13 9:16 ` Anisse Astier
2019-03-03 1:52 ` Christian Stewart
2019-03-03 21:17 ` Peter Korsgaard [this message]
2019-03-03 21:16 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ef7nk68c.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox