From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libftdi1: fix python build with cmake < 3.7
Date: Sun, 20 Jan 2019 07:35:05 +0200 [thread overview]
Message-ID: <87ef97oprq.fsf@tarshish> (raw)
In-Reply-To: <20190119205308.31175-1-fontaine.fabrice@gmail.com>
Hi Fabrice,
On Sat, Jan 19 2019, Fabrice Fontaine wrote:
> Fixes:
> - http://autobuild.buildroot.org/results/1091872e2b77d789e361d1ddefd235c738933c55
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> ...n-CMakeLists.txt-fix-build-with-cmake-3.7.patch | 34 ++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
> create mode 100644 package/libftdi1/0005-python-CMakeLists.txt-fix-build-with-cmake-3.7.patch
>
> diff --git a/package/libftdi1/0005-python-CMakeLists.txt-fix-build-with-cmake-3.7.patch b/package/libftdi1/0005-python-CMakeLists.txt-fix-build-with-cmake-3.7.patch
> new file mode 100644
> index 0000000000..c9fcb0ee4f
> --- /dev/null
> +++ b/package/libftdi1/0005-python-CMakeLists.txt-fix-build-with-cmake-3.7.patch
> @@ -0,0 +1,34 @@
> +From ddfbe611fd273ea6a0c1ac86c184fa8b395fa2fe Mon Sep 17 00:00:00 2001
> +From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +Date: Sat, 19 Jan 2019 21:09:22 +0100
> +Subject: [PATCH] python/CMakeLists.txt: fix build with cmake < 3.7
> +
> +VERSION_GREATER_EQUAL has been added only in cmake 3.7:
> +https://cmake.org/cmake/help/v3.7/release/3.7.html
> +
> +So replace this statement by NOT CMAKE_VERSION VERSION_LESS
> +
> +Fixes:
> + - http://autobuild.buildroot.org/results/1091872e2b77d789e361d1ddefd235c738933c55
> +
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +[Upstream status:
> +http://developer.intra2net.com/mailarchive/html/libftdi/2019/msg00009.html]
> +---
> + python/CMakeLists.txt | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/python/CMakeLists.txt b/python/CMakeLists.txt
> +index 7bdd9f9..376dae6 100644
> +--- a/python/CMakeLists.txt
> ++++ b/python/CMakeLists.txt
> +@@ -1,5 +1,5 @@
> + # workaround for cmake bug #0013449
> +- if ( NOT DEFINED CMAKE_FIND_ROOT_PATH OR CMAKE_VERSION VERSION_GREATER_EQUAL 3.0.0 )
> ++ if ( NOT DEFINED CMAKE_FIND_ROOT_PATH OR NOT CMAKE_VERSION VERSION_LESS 3.0.0 )
VERSION_GREATER_EQUAL is added in Buildroot patch 0004. Why not fix it
there?
> + find_package ( SWIG )
> + else ()
> + find_program ( SWIG_EXECUTABLE NAMES swig2.0 swig )
> +--
> +2.14.1
> +
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2019-01-20 5:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-19 20:53 [Buildroot] [PATCH 1/1] libftdi1: fix python build with cmake < 3.7 Fabrice Fontaine
2019-01-20 5:35 ` Baruch Siach [this message]
2019-01-20 8:55 ` Fabrice Fontaine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ef97oprq.fsf@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox