From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] pcm-tools: new package
Date: Sat, 08 Dec 2018 10:43:33 +0100 [thread overview]
Message-ID: <87efas5p6i.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20181207012023.29474-1-casantos@datacom.com.br> (Carlos Santos's message of "Thu, 6 Dec 2018 23:20:23 -0200")
>>>>> "Carlos" == Carlos Santos <casantos@datacom.com.br> writes:
> Processor Counter Monitor (PCM) is an application programming interface
> (API) and a set of tools based on the API to monitor performance and
> energy metrics of Intel(R) Core(TM), Xeon(R), Atom(TM) and Xeon Phi(TM)
> processors.
> This package contains a patch on the pmu-query.py script to look for the
> pcm-core program at the default path. It's not nice to have a Buildroot
> specific patch but let's use one while we look for a solution that is
> acceptable upstream.
> Signed-off-by: Carlos Santos <casantos@datacom.ind.br>
> ---
> Supersedes: https://patchwork.ozlabs.org/patch/864801/
> CC: Romain Naour <romain.naour@gmail.com>
> CC: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> Changes v1->v2
> - Update to version 201812
> - Do not build the test daemon
> - Drop the patch on the test daemon, that we don't build
> - Drop a patch already applied upstream
> - Update the pmu-query.py patch
> - Make the changes suggested by Romain Naour and Thomas Petazzoni
> +config BR2_PACKAGE_PCM_TOOLS
> + bool "pcm-tools"
> + depends on BR2_i386 || BR2_x86_64
> + select BR2_PACKAGE_HWDATA
> + select BR2_PACKAGE_HWDATA_PCI_IDS
It is written in C++, so I've added the BR2_INSTALL_LIBSTDCPP dependency
and a comment.
> + help
> + Processor Counter Monitor (PCM) is an application programming
> + interface (API) and a set of tools based on the API to monitor
> + performance and energy metrics of Intel(R) Core(TM), Xeon(R),
> + Atom(TM) and Xeon Phi(TM) processors.
> +
> + Requires a kernel with X86_MSR enabled.
It makes more sense to just forcible enable it in linux.mk if pcm-tools
is enabled, similar to how we do it for other packages.
Committed with these 2 fixes, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2018-12-08 9:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 14:03 [Buildroot] [PATCH] hwdata: bumb to version 0.308 Carlos Santos
2018-01-23 14:03 ` [Buildroot] [PATCH] pcm-tools: new package Carlos Santos
2018-03-31 14:57 ` Romain Naour
2018-04-01 14:16 ` Thomas Petazzoni
2018-04-03 2:02 ` Carlos Santos
2018-12-07 1:32 ` Carlos Santos
2018-12-07 11:15 ` Thomas Petazzoni
2018-12-07 11:41 ` Carlos Santos
2018-12-07 1:20 ` [Buildroot] [PATCH v2] " Carlos Santos
2018-12-08 9:43 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efas5p6i.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox