Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] rpm: really take DEPENDENCIES into account
Date: Mon, 26 Nov 2018 17:16:12 +0100	[thread overview]
Message-ID: <87efb7yfub.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20181119111945.17683-1-thomas.petazzoni@bootlin.com> (Thomas Petazzoni's message of "Mon, 19 Nov 2018 12:19:45 +0100")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > Commit e7af4033c32560594ddbd457b68f6d3713662a26 ("rpm: use the new
 > gettext logic") introduced a really nasty bug: by adding
 > $(TARGET_NLS_DEPENDENCIES) to RPM_DEPENDENCIES, it completely
 > overwrote the existing value of RPM_DEPENDENCIES, entirely masking all
 > mandatory RPM dependencies.

 > rpm is fairly towards the end of the alphabet, and most other
 > mandatory dependencies (berkeleydb, host-pkgconf, file and popt)
 > appear earlier by alphabetic ordering. Only zlib was afterwards, but
 > since file depends on zlib, it was always built before. This probably
 > explains why our autobuilders haven't encountered a single build
 > failure.

 > However, a simple "make rpm" clearly exhibits the failure, and
 > obviously the upcoming per-package folder mechanism makes such bugs
 > even more obvious.

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
 > ---
 > I don't know who was this guy @free-electrons.com who did this silly
 > change, but something wasn't quite right with him :-)

Committed to 2018.02.x and 2018.08.x, thanks.

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2018-11-26 16:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-19 11:19 [Buildroot] [PATCH] rpm: really take DEPENDENCIES into account Thomas Petazzoni
2018-11-19 15:06 ` Peter Korsgaard
2018-11-26 16:16 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87efb7yfub.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox