Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Main Makefile Have "make savedefconfig" show where the file is being written to.
Date: Thu, 01 Mar 2018 22:21:45 +0100	[thread overview]
Message-ID: <87efl3h4pi.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <dd0ef897-7b93-4c58-6f6f-a33e33f4e28a@mind.be> (Arnout Vandecappelle's message of "Thu, 1 Mar 2018 20:50:30 +0100")

>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

 > On 27-02-18 12:28, Christopher McCrory wrote:
 >> Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
 >> ---
 >> Makefile | 1 +
 >> 1 file changed, 1 insertion(+)
 >> 
 >> diff --git a/Makefile b/Makefile
 >> index ec39bcdb9c..4ac2435a9c 100644
 >> --- a/Makefile
 >> +++ b/Makefile
 >> @@ -927,6 +927,7 @@ savedefconfig: $(BUILD_DIR)/buildroot-config/conf prepare-kconfig
 >> --savedefconfig=$(if $(DEFCONFIG),$(DEFCONFIG),$(CONFIG_DIR)/defconfig) \
 >> $(CONFIG_CONFIG_IN)
 >> @$(SED) '/BR2_DEFCONFIG=/d' $(if $(DEFCONFIG),$(DEFCONFIG),$(CONFIG_DIR)/defconfig)
 >> +	@echo "Saved to $(DEFCONFIG)"

 >  If BR2_DEFCONFIG is not set, you'll get "Saved to " which is a bit weird. So
 > change into:

 > 	@echo "Saved to $(if $(DEFCONFIG),$(DEFCONFIG),$(CONFIG_DIR)/defconfig)"

 >  But now $(if $(DEFCONFIG),$(DEFCONFIG),$(CONFIG_DIR)/defconfig) is used 3
 > times, so perhaps it's worth adding a variable for it. I can't think of a good
 > name for it unfortunately.

Perhaps we could just set DEFCONFIG to $(CONFIG_DIR)/defconfig if empty?

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2018-03-01 21:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-27 11:28 [Buildroot] [PATCH 1/1] Main Makefile Have "make savedefconfig" show where the file is being written to Christopher McCrory
2018-02-27 21:02 ` Thomas Petazzoni
2018-03-01 19:50 ` Arnout Vandecappelle
2018-03-01 21:21   ` Peter Korsgaard [this message]
2018-03-02  8:05     ` Arnout Vandecappelle
2018-03-02  8:17       ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87efl3h4pi.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox