From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 06/10] package/Makefile.in: adjust LDFLAGS for elf2flt
Date: Fri, 08 Apr 2016 14:28:59 +0200 [thread overview]
Message-ID: <87egagp9mc.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1459450815-6494-7-git-send-email-thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Thu, 31 Mar 2016 21:00:11 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> So far, our LDFLAGS for the BR2_BINFMT_FLAT case were only used on
> Blackfin. However, passing -elf2flt in LDFLAGS is wrong. Indeed,
> LDFLAGS are not linker flags, but flags passed to the compiler when
> linking.
> If you pass -elf2flt to the compiler when linking, it is understood as
> "-e lf2flt", i.e "the entry point is named lf2flt", which isn't
> exactly the intention. We in fact need to pass -Wl,-elf2flt in LDFLAGS
> as well, so that the compiler passes -elf2flt down to the linker.
> For some reason, this option does not cause an issue with the Blackfin
> toolchain, but it does with either a Buildroot toolchain for Cortex-M
> or an OSELAS toolchain for Cortex-M. We have verified that passing
> -Wl,-elf2flt continues to work with the Blackfin toolchain.
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Committed, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2016-04-08 12:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 19:00 [Buildroot] [PATCH v3 00/10] ARM Cortex-M support and STM32 defconfigs Thomas Petazzoni
2016-03-31 19:00 ` [Buildroot] [PATCH v3 01/10] uclibc: use upstreamed patch for ARM Thumb simplification Thomas Petazzoni
2016-04-08 8:20 ` Peter Korsgaard
2016-03-31 19:00 ` [Buildroot] [PATCH v3 02/10] uclibc: context functions are not Thumb-compatible Thomas Petazzoni
2016-04-08 8:24 ` Peter Korsgaard
2016-03-31 19:00 ` [Buildroot] [PATCH v3 03/10] musl: build broken on Thumb, use ARM mode Thomas Petazzoni
2016-04-08 10:09 ` Peter Korsgaard
2016-03-31 19:00 ` [Buildroot] [PATCH v3 04/10] toolchain-buildroot: update glibc comment for noMMU Thomas Petazzoni
2016-04-08 10:09 ` Peter Korsgaard
2016-03-31 19:00 ` [Buildroot] [PATCH v3 05/10] toolchain-buildroot: don't show musl on noMMU platforms Thomas Petazzoni
2016-04-08 10:10 ` Peter Korsgaard
2016-03-31 19:00 ` [Buildroot] [PATCH v3 06/10] package/Makefile.in: adjust LDFLAGS for elf2flt Thomas Petazzoni
2016-04-08 12:28 ` Peter Korsgaard [this message]
2016-03-31 19:00 ` [Buildroot] [PATCH v3 07/10] elf2flt: use new upstream site and add ARM patch Thomas Petazzoni
2016-04-01 15:08 ` Waldemar Brodkorb
2016-03-31 19:00 ` [Buildroot] [PATCH v3 08/10] afboot-stm32: use the Buildroot toolchain Thomas Petazzoni
2016-03-31 19:00 ` [Buildroot] [PATCH v3 09/10] configs/stm32f429_disco: new configuration for STM32F429 Discovery board Thomas Petazzoni
2016-03-31 19:00 ` [Buildroot] [PATCH v3 10/10] configs/stm32f469_disco: new configuration for STM32F469 " Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87egagp9mc.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox