From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pkg-generic: improve incorrectly used package detection
Date: Sun, 03 Jan 2016 22:15:57 +0100 [thread overview]
Message-ID: <87egdymkj6.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1451606483-29096-1-git-send-email-yann.morin.1998@free.fr> (Yann E. MORIN's message of "Fri, 1 Jan 2016 01:01:23 +0100")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Currently, the check that packages we build are indeed enabled is done
> at the time a package is configured.
> This can come quite late in the build process, and does not provide
> direct knowledge of the real culprit for the incorrect dependency.
> However, we can improve these two issues quite easily, albeit at the
> expense of a very slightly more complicated make code.
> First, the check can not be done at the time we define the package, i.e.
> in the inner-generic-pacakge, because all its dependencies might have
> not been parsed yet, so we can't yet know whether it is enabled or not
> (because we can't match the package name of the dependency to its
> Kconfig variable yet).
> But then, we know we have all packages definitions after we scanned the
> the bundled packages, kernel, bootloaders and toolchains, as well as the
> br2-external tree (if any).
> So, at this location, we iterate through the list of enabled packages,
> and check that the packages they each depend on are indeed enabled.
> This allows us to:
> 1- do the check very early, before any build action,
> 2- report on the exact offending package very easily.
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Committed, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2016-01-03 21:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-01 0:01 [Buildroot] [PATCH] pkg-generic: improve incorrectly used package detection Yann E. MORIN
2016-01-01 16:49 ` Romain Naour
2016-01-01 16:58 ` Yann E. MORIN
2016-01-01 17:01 ` Yann E. MORIN
2016-01-03 21:15 ` Peter Korsgaard [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-12-30 21:27 Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87egdymkj6.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox