Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/harfbuzz: fix static linking for test-unicode program
Date: Mon, 25 May 2015 22:14:53 +0200	[thread overview]
Message-ID: <87egm4za6a.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <5562DD0F.8020707@openwide.fr> (Romain Naour's message of "Mon, 25 May 2015 10:27:59 +0200")

>>>>> "Romain" == Romain Naour <romain.naour@openwide.fr> writes:

Hi,

>> So shouldn't we fix icu-uc.pc instead of hardcoding the need for
 >> -lstdc++ in harfbuzz?

 > Yes you're right, but it would require invasive change in icu build system.
 > If we want to do things right, we needs to patch configure.ac to add -lstdc++
 > when --enable-static is passed to icu's configure script.

Why only add it conditionally? The Libs.private stuff is only used for
static linking, so it can just be added unconditionally.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2015-05-25 20:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-18 22:37 [Buildroot] [PATCH] package/harfbuzz: fix static linking for test-unicode program Romain Naour
2015-05-21 10:37 ` Thomas Petazzoni
2015-05-25  8:27   ` Romain Naour
2015-05-25 20:14     ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87egm4za6a.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox